pkgsrc-Bulk archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: use of ls in mk/bulk/post-build



Todd Vierling <tv%duh.org@localhost> wrote:
> On Mon, 11 Apr 2005, Jan Schaumann wrote:
> 
> > In rev 1.49 of  pkgsrc/mk/bulk/post-build, you committed
> 
> Sorry I haven't gotten back to you on this yet....
> 
> > -chdir($USR_PKGSRC);
> > -system("find . -name $BROKENFILE -print -o -name $BROKENWRKLOG -print | 
> > $GTAR -T - -plcf - | (cd $FTP; $GTAR -plxf -)");
> > +chdir($vars{USR_PKGSRC});
> > +my_system("/bin/ls -1 $vars{BROKENFILE} $vars{BROKENWRKLOG} 
> > */*/$vars{BROKENFILE} */*/$vars{BROKENWRKLOG} 2>/dev/null | $vars{GTAR} -T 
> > - -plcf - | (cd $vars{FTP}; $vars{GTAR} -plxf -)");
> >
> > On some systems, this now leads to too many arguments to ls(1),
> > subsequently producing an empty bulk-log.  What was wrong with using
> > find(1)?
> 
> NFS slowness, for a nfs-mounted pkgsrc.
> 
> Hm.  This is ugly.  I suppose it can go back to find, but I may try to find
> a new way to do this in the future.

This still hasn't been fixed.  I'd really like to have a functional
post-build on the new branch -- can we please revert this change to use
find(1) again?  It's better to have it be slow over NFS than to not have
it working at all on some platforms.

-Jan

-- 
42

Attachment: pgpvupdCPu3ez.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index