Subject: pkg/37408: buildlink3.mk files should not be included more often than necessary
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <rillig@NetBSD.org>
List: pkgsrc-bugs
Date: 11/20/2007 19:15:00
>Number:         37408
>Category:       pkg
>Synopsis:       buildlink3.mk files should not be included more often than necessary
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 20 19:15:00 +0000 2007
>Originator:     Roland Illig
>Release:        
>Organization:
>Environment:
>Description:
Currently, the buildlink3.mk files are included many times, although doing that once is usually enough.

>How-To-Repeat:
cd /usr/pkgsrc/graphics/gimp-refocus-it
bmake show-all-features

(This shows "glob" many times, since it is mentioned in one of the buildlink3.mk files. It should only be mentioned once for every package that requests it.)

>Fix:
Put the .include lines between the multiple-inclusion guards.