Subject: Re: pkg/36804 (ktorrent compile error on current)
To: None <abs@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,>
From: Bernd Ernesti <pr200707@veego.de>
List: pkgsrc-bugs
Date: 08/22/2007 20:35:02
The following reply was made to PR pkg/36804; it has been noted by GNATS.
From: Bernd Ernesti <pr200707@veego.de>
To: David Brownlee <abs@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/36804 (ktorrent compile error on current)
Date: Wed, 22 Aug 2007 22:32:28 +0200
On Tue, Aug 21, 2007 at 06:11:06PM +0100, David Brownlee wrote:
> I don't have a current system on which to test - would it be
> possible for you to test this updated patch-ab?
Unfortunally this won't work:
ChartDrawer.cc:275:31: warning: "__NetBSD_Version__" is not defined
ChartDrawer.cc: In member function 'void kt::ChartDrawer::AddValue(size_t, double, bool)':
ChartDrawer.cc:276: error: 'isnan' was not declared in this scope
ChartDrawer.cc:276: error: 'isinf' was not declared in this scope
gmake[3]: *** [ChartDrawer.lo] Error 1
I guess you need to include sys/param.h too, like this:
--- plugins/stats/ChartDrawer.cc.orig 2007-07-23 18:43:08.000000000 +0200
+++ plugins/stats/ChartDrawer.cc 2007-08-22 22:26:14.000000000 +0200
@@ -25,6 +25,9 @@
int isinf(double x) { return !finite(x) && x==x; }
#endif
+#ifdef Q_OS_NETBSD
+#include <sys/param.h>
+#endif
namespace kt {
@@ -272,6 +275,8 @@
#ifdef USE_SOLARIS
if(isnand(val) || (isinf(val)))
+#elif defined(Q_OS_NETBSD) && __NetBSD_Version__ < 499002000
+ if(isnan(val) || isinf(val))
#else
if(std::isnan(val) || (std::isinf(val)))
#endif
Bernd