Subject: pkg/36767: [patches included] imap-uw for Darwin 8.* (Tiger) needs proper BUILD_TARGET.Darwin
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Mark E. Perkins <perkinsm@bway.net>
List: pkgsrc-bugs
Date: 08/10/2007 16:15:01
>Number: 36767
>Category: pkg
>Synopsis: [patches included] imap-uw for Darwin 8.* (Tiger) needs proper BUILD_TARGET.Darwin
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Aug 10 16:15:01 +0000 2007
>Originator: Mark E. Perkins
>Release: Darwin 8.10.0 Power Macintosh
>Organization:
>Environment:
System: Darwin crow.fringe.mep 8.10.0 Darwin Kernel Version 8.10.0: Wed May 23 16:50:59 PDT 2007; root:xnu-792.21.3~1/RELEASE_PPC Power Macintosh
>Description:
Attempting to build mail/imap-uw on Darwin 8.10.0 produces notice shown below.
Even after patching for this problem, there is still the run-time problem noted in pkg/35592
(see patches below for suggested composite fix), which leak out to other packages that need
the c-client library (i.e., Pine). Suggested patches should fix all of this.
===> Building for imap-uw-2006j2nb2
You are building for OLD versions of Mac OS X. This build is
NOT suitable for modern versions of Mac OS X, such as Tiger,
which use PAM-based authentication. If you want to build for
modern Mac OS X, you should use make oxp instead.
Do you want to continue this build? Type y or n please:
n
*** Error code 1
Stop.
>How-To-Repeat:
(b)make in mail/imap-uw on a Darwin 8.* (Tiger) system
>Fix:
Patch below for Makefile includes the Makefile patch from obache@ in pkg/35592.
Note that numeric comparison on OS_VERSION (8.10.0 here) will throw an error,
hence the string-match usage.
Patch below for buildlink3.mk is identical to that from obache@ in pkg/35592.
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/imap-uw/Makefile,v
retrieving revision 1.120
diff -b -u -r1.120 Makefile
--- Makefile 5 Aug 2007 18:41:52 -0000 1.120
+++ Makefile 10 Aug 2007 15:33:10 -0000
@@ -39,7 +39,14 @@
.else
BUILD_TARGET.Linux= slx
.endif
+.if ${OPSYS} == "Darwin"
+ LDFLAGS+= -flat_namespace
+. if !empty(OS_VERSION:M8.*)
+BUILD_TARGET.Darwin= oxp
+. else
BUILD_TARGET.Darwin= osx
+. endif
+.endif
.if ${OPSYS} == "IRIX"
. if ${OS_VERSION} >= 6.5
BUILD_TARGET.IRIX= sg6
Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mail/imap-uw/buildlink3.mk,v
retrieving revision 1.11
diff -b -u -r1.11 buildlink3.mk
--- buildlink3.mk 5 Aug 2007 04:51:34 -0000 1.11
+++ buildlink3.mk 10 Aug 2007 15:33:10 -0000
@@ -11,10 +11,15 @@
BUILDLINK_PACKAGES+= imap-uw
BUILDLINK_ORDER:= ${BUILDLINK_ORDER} ${BUILDLINK_DEPTH}imap-uw
+.include "../../mk/bsd.fast.prefs.mk"
+
.if !empty(IMAP_UW_BUILDLINK3_MK:M+)
BUILDLINK_API_DEPENDS.imap-uw+= imap-uw>=2004
BUILDLINK_ABI_DEPENDS.imap-uw+= imap-uw>=2006j2nb1
BUILDLINK_PKGSRCDIR.imap-uw?= ../../mail/imap-uw
+. if ${OPSYS} == "Darwin"
+BUILDLINK_LDFLAGS.imap-uw+= -flat_namespace
+. endif
.endif # IMAP_UW_BUILDLINK3_MK
.include "../../security/openssl/buildlink3.mk"