Subject: PR/25337 CVS commit: pkgsrc/x11/wdm
To: None <reed@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,>
From: Jeremy C. Reed <reed@netbsd.org>
List: pkgsrc-bugs
Date: 10/18/2006 20:25:01
The following reply was made to PR pkg/25337; it has been noted by GNATS.

From: "Jeremy C. Reed" <reed@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/25337 CVS commit: pkgsrc/x11/wdm
Date: Wed, 18 Oct 2006 20:23:15 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	reed
 Date:		Wed Oct 18 20:23:15 UTC 2006
 
 Modified Files:
 	pkgsrc/x11/wdm: Makefile PLIST distinfo
 	pkgsrc/x11/wdm/files: wdm.sh
 	pkgsrc/x11/wdm/patches: patch-aa
 
 Log Message:
 Update to version 1.28.
 
 This is for PR 25337. From looking at the wdm ChangeLog it looks
 like the daemon mode was fixed on 05-Sep-2003 and was released in
 the 1.26 release.
 
 Thank you for testing, Dan.
 
 Use $VARBASE for "fakehome".
 
 Adds new locale files.
 
 In wdm rc.d script add -daemon for command arguments.
 Also use VARBASE for pid file.
 
 Change patch-aa to be for the examples config directory.
 (I didn't notice that old patch there was needed nor did I see
 any commit message saying why.)
 
 ChangeLog has:
 
 26-Mar-2005 16:56  [wdm.1.28] prepare for release
 			none
 
 26-Mar-2005 16:32  [wdm.1.27] patch by Thomas Glanzmann
 			I don't think those changes was necessary, but if they
 			make someone's life little better, why not apply it? :)
 			It is said, that without these, wdm didn't work
 			correctly on sunray servers
 
 26-Mar-2005 14:26  [wdm.1.27] fix pam_open_session
 			"I'm running wdm-1.27 on FreeBSD 5.2-CURRENT. Since
 			version 1.26, PAM code seems not to work. ( This means
 			that ssh-agent is not started even if pam_ssh.so is
 			enabled. )
 
 			I have checked src/wdm/session.c. If system has
 			setusercontext(), I guess that pam_open_session() will
 			never be called." Reported by Kan Sasaki
 			<sasaki@fcc.ad.jp>
 
 22-Mar-2005 21:09  [wdm.1.27] update aa code
 			Antialiasing API has chaged in new wmaker. I need to
 			update code. New code uses some #ifdefs. They should go
 			away soon.
 
 20-Mar-2005 16:46  [wdm.1.27] update config
 			config file for aegis needs to be updated because
 			create_symlinks_before_build field is obsolete. I need
 			to use development_directory_style.source_file_symlink
 			field.
 
 19-Mar-2005 17:17  [wdm.1.27] fix fd leak - II
 			Last descriptor leaked si return value of mkstemp
 			function. I'm totally forgot, that this function
 			returns value. Thanks Michael Gernoth for reminding me
 			about it. :)
 
 19-Mar-2005 13:31  [wdm.1.27] fix fd leak - I
 			wdm leaks file descriptors to child processes. That's
 			bad. This change fixed all leaked pipes and file
 			descriptor for log. The only one left is leaked
 			descriptor for removed auth file
 
 09-Oct-2004 14:12  [wdm.1.27] Welsh translation
 			Welsh translation sent to me by Kevin Donnelly
 			<kevin@dotmon.com>
 
 05-Oct-2004 21:53  [wdm.1.27] problem with xdmcp and ipv6
 			Jennifer Elaan <jen@elaan.com> reported "that wdm drops
 			the connection to the X server after login but before
 			running Xsession.". Later she mailed me with "My
 			partner just isolated and corrected this problem. The
 			culprit is bad handling of IPv6 packets, which triggers
 			a debug message with invalid arguments."
 
 05-Oct-2004 21:49  [wdm.1.27] rebuild
 			glibc was updated. I need rebuild
 
 06-Mar-2004 12:52  [wdm.1.27] fix AUTHORS
 			add latest translators and contributors to AUTHORS
 			file.
 
 28-Feb-2004 14:19  [wdm.1.27] prepare for release
 			update NEWS
 
 28-Feb-2004 13:30  [wdm.1.26] fix warning on FreeBSD
 			found another warning while compiling on FreeBSD. "src/
 			wdm/util.c:139: warning: implicit declaration of
 			function `sigsetmask'." I don't see that on Linux.
 
 			I simplified part dealing with signals. The setpgrp
 			function differs on FreeBSD and Linux, but setpgid is
 			not. I tested everything at least to compile on Linux
 			and FreeBSD. I hope it will work on other BSD systems
 			as well.
 
 28-Feb-2004 13:28  [wdm.1.26] remove ExitLogin
 			ExitLogin is generally not needed. There is new option
 			to configure --enable-exitlogin for those who wants it.
 
 23-Feb-2004 11:35  [wdm.1.26] make clean
 			make clean target should remove everything that can be
 			rebuild wiht simple make. including generated config
 			files.
 
 23-Feb-2004 11:18  [wdm.1.26] fix text in INSTALL file
 			Section 4 about make clean and make distclean is not
 			correct. Also name of configs directory should be fixed
 			(it refers to ./config).
 
 22-Feb-2004 13:27  [wdm.1.26] typo in configure help
 			it displays BLACLBOX_PATH instead of BLACKBOX_PATH
 
 22-Feb-2004 13:11  [wdm.1.26] warnings in src/wdm/resource.c
 			src/wdm/resource.c cannot be recompiled with gcc-3.3.2
 			because of warnings: "src/wdm/resource.c:231: warning:
 			dereferencing type-punned pointer will break strict-
 			aliasing rules".
 
 			Everything that raised that warning was converted to
 			union. I hope nothing is broken.
 
 22-Feb-2004 10:37  [wdm.1.26] FreeBSD compatibility - III
 			don't use -D flag of install which is GNU specific and
 			is not available in BSD install. reported by Geir Ove
 			Myhr <myhr+wdm@fysmat.ntnu.no>
 
 21-Feb-2004 14:07  [wdm.1.26] obsolete header
 			remove inclusion of <malloc.h> it is obsolete and
 			should be replaced with <stdlib.h>. reported by Geir
 			Ove Myhr <myhr+wdm@fysmat.ntnu.no>
 
 21-Feb-2004 14:03  [wdm.1.26] i18n
 			Don't call gettext (directly) in wdmLogin if I18N is
 			not defined. reported by Geir Ove Myhr
 			<myhr+wdm@fysmat.ntnu.no>
 
 21-Feb-2004 13:54  [wdm.1.26] FreeBSD compatibility - II
 			remove wrong prototypes for setgrent etc. reported by
 			Geir Ove Myhr <myhr+wdm@fysmat.ntnu.no>
 
 21-Feb-2004 13:45  [wdm.1.26] FreeBSD compatibility
 			include <signal.h> into loghelpers.c explicitly.
 			reported by Geir Ove Myhr <myhr+wdm@fysmat.ntnu.no>
 
 01-Dec-2003 22:40  [wdm.1.26] wdm - SELinux support
 			SELinux support added by Tom Vogt <tom@lemuria.org>
 
 19-Nov-2003 22:48  [wdm.1.26] french translation
 			added french translation by Mathieu Roy
 			<yeupou@gnu.org>
 
 22-Sep-2003 21:18  [wdm.1.26] fix debug compilation
 			there's some calls to Debug left, can be reproduced
 			with --enable-debug option specified to configure
 			(reported by vlaad). I removed offending code, because
 			it's not used anywhere.
 
 19-Sep-2003 00:27  [wdm.1.26] prepare for release
 			update NEWS
 
 18-Sep-2003 21:27  [wdm.1.25] fix etc/configre.cook
 			etc/configure.cook fails if PACKAGE_VERSION is
 			undefined
 
 13-Sep-2003 11:23  [wdm.1.25] remove xdm sources
 			wdm doesn't require separate xdm source tree to build.
 			I never used this source tree for anything. I remove
 			xdm sources from tarball.
 
 13-Sep-2003 10:16  [wdm.1.25] fix pam rights escalation
 			this bug and fix is from kdm. I don't know if it
 			actually fixes something. I only added check for return
 			value of pam_setcred function call.
 
 10-Sep-2003 00:49  [wdm.1.25] add README.aa
 			this file should contain simple recipe how to enable
 			aa.
 
 07-Sep-2003 22:16  [wdm.1.25] draw simple test panel
 			create two panels, and make them switch with buttons on
 			top.
 
 07-Sep-2003 11:24  [wdm.1.25] wdm doesn't stop if parent wdm process is stopped
 			the problem is in new logging code. parent process
 			should process signals and kill it's child.
 
 05-Sep-2003 09:42  [wdm.1.25] last warning
 			I missed one warning :( because of missing --enable-
 			aafont option
 
 05-Sep-2003 00:10  [wdm.1.25] fix daemon mode
 			src/wdm/resource.c sets the debug value to 1 by
 			default. It used to be 0 by default. This causes a
 			problem in that a value of 1 prevents wdm from running
 			as a daemon.  Line 140 of src/wdm/dm.c contains an if
 			statement that only calls BecomeDaemon if debugLevel ==
 			0. Reported by Noah Meyerhans <noahm@debian.org>
 
 04-Sep-2003 09:42  [wdm.1.25] fix czech translation
 			updated cs.po by Vladimir Nadvornik <nadvornik@suse.cz>
 
 02-Sep-2003 22:02  [wdm.1.25] AC_CHECK_DECLS -> AC_DECL_SYS_SIGLIST
 			there's specialized version in autoconf. why not use
 			it? :)
 
 01-Sep-2003 22:49  [wdm.1.25] fix warnings
 			due to bug in autoconf `const' was defined to be empty
 			in config.h. that's bad. some warnings disappeared in
 			build environment.
 
 31-Aug-2003 22:31  [wdm.1.25] remove support for DECnet and Chaos
 			same sutuation as with STREAMSCONN. I'm not sure that
 			code can work at all.
 
 31-Aug-2003 21:12  [wdm.1.25] fix Makefile
 			The distclean rule in Makefile.in never deletes bin/
 			libwdm.a, and consequently the call to rmdir bin fails.
 			Reported by Noah Meyerhans <noahm@debian.org>
 
 31-Aug-2003 20:59  [wdm.1.25] fix tarball creation
 			tarball is named .bz2 but compressed with gzip. fix it.
 
 31-Aug-2003 19:24  [wdm.1.25] remove support for sysv streams
 			sysv streams was never supported by wdm, there was
 			never option to enable it. I cannot test this code
 			because I dont't have access to OS wih streams. I
 			remove it.
 
 31-Aug-2003 17:25  [wdm.1.25] czech translation
 			add czech translation by Vladimir Nadvornik
 			<nadvornik@suse.cz>
 
 16-Jul-2003 23:33  [wdm.1.25] rename closeAction function
 
 03-Jul-2003 12:48  [wdm.1.25] function to add section buttons in wdmPrefs
 			Very basic functions. panels and buttons are not
 			destroyed, views not switching. Just adding buttons.
 
 01-Jul-2003 13:01  [wdm.1.25] fix copyright notice in TestLogin
 
 01-Jul-2003 12:28  [wdm.1.25] spanish translation
 			add spanish translation by Manolo Padron Martinez
 			<manolopm@cip.es>
 
 01-Jul-2003 11:48  [wdm.1.25] fix TestLogin
 			TestLogin is broken now, because wdmLogin
 
 17-Jun-2003 23:10  [wdm.1.25] run some tests via sudo
 			some tests nned root priviledges. (ie test for
 			switching users functions).
 
 17-Jun-2003 17:09  [wdm.1.25] create common parts of interface for wdmPrefs
 			buttons like "close" and "save", section selector,
 			should be common for all sections.
 
 15-Jun-2003 20:49  [wdm.1.25] remove old env functions - III
 			replace remaining printEnv and freeEnv with WDMFreeEnv
 			and WDMPrintEnv
 
 15-Jun-2003 20:27  [wdm.1.25] remove old env functions - II
 			replace setEnv and putEnv with WDMSetEnv and WDMPutEnv
 
 15-Jun-2003 14:55  [wdm.1.25] remove old env functions - I
 			getEnv function replaced with WDMGetEnv
 
 15-Jun-2003 12:30  [wdm.1.25] quick fix for dup2/3 problem
 			wdm/wdmlogin communication tied to fd #3, that's bad,
 			because if any other file opened, then communication
 			channel breaks. Solution is to pass filedescriptor as
 			commandline parameter to wdmLogin.
 
 13-Jun-2003 11:10  [wdm.1.25] stricter compiler options
 			add -Werror to CFLAGS, so I will never ignore warnings
 			in future. Fix all current warnings
 
 12-Jun-2003 23:39  [wdm.1.25] add "en" locale
 			add en.po, replace long default help text string with a
 			lot shorter one. C locale will get only short help
 			text. User should use en locale to get full english
 			help text.
 
 12-Jun-2003 10:19  [wdm.1.25] WDMPrintEnv function
 			It's better to have it...
 
 11-Jun-2003 17:45  [wdm.1.25] fix install script
 			install part of Makefile should create directory used
 			as fakeroot. If that directory doesn't exists then aa
 			will not work.
 
 11-Jun-2003 14:42  [wdm.1.25] GPL notice in prefs.c
 			I forgot to add GPL notice to prefs.c
 
 10-Jun-2003 23:13  [wdm.1.25] wdmChooser
 			create wdmChooser skeleton.
 
 10-Jun-2003 22:51  [wdm.1.25] wdmPrefs
 			wdmPrefs will support only proplist format configs.
 			first version should support  all options for wdmLogin
 			available in proplist config. (geometry, aafonts,
 			multibyte). This  change will introduce the program
 			skeleton.
 
 09-Jun-2003 23:19  [wdm.1.25] automate version numbers
 			get version number from branch
 
 09-Jun-2003 11:07  [wdm.1.25] automate build of wdm-current
 			development builds should not build tarball at all.if
 			requested it should build wdm-current.tar.bz2. only
 			integration build creates "real" tarballs
 
 09-Jun-2003 00:04  [wdm.1.25] fix ChangeLog
 			after migration to new repository some wrong messages
 			goes into ChangeLog. remove it.
 
 08-Jun-2003 23:58  [wdm.1.25] fix problems with bl* symlinks
 			build fails with error 'symlink already exists'
 
 07-Jun-2003 13:30  [wdm.1.25] -a option to config
 			animation option should be taken from wdmLogin-config.
 			command line will be here for few releases for
 			compatibility.
 
 06-Jun-2003 18:58  [wdm.1.25] prepare for release
 			update NEWS, INSTALL, version in configure.ac
 
 06-Jun-2003 17:49  [wdm.1.24] #ifdef parts for antialiasing
 			fonts antialiasing available only in cvs snapshots.
 			Make it conditional.
 
 06-Jun-2003 15:46  [wdm.1.24] fix AA
 			wdmLogin crashes when started with AA enabled.
 
 05-Jun-2003 17:30  [wdm.1.24] fix i18n build/install
 			if msgfmt is not found Makefile is still tries to
 			create .mo and install it. (reported by vlaad)
 
 05-Jun-2003 17:13  [wdm.1.24] geometry option for wdmLogin
 			geometry option will allow wdmLogin panel to be moved
 			and resized. That option will be the first in
 			wdmLogin's own config file.
 
 04-Jun-2003 16:49  [wdm.1.24] fix WDMCheckPLDictionary
 			current implementation have some disadvantages.
 
 04-Jun-2003 16:16  [wdm.1.24] fix debug test
 			debug test is broken.
 
 03-Jun-2003 21:41  [wdm.1.24] add warning to Makefile.in
 			warn that Makefile.in is generated. Also remove some
 			duplicated variables from Makefile.head
 
 03-Jun-2003 18:28  [wdm.1.24] fix wstrndup
 			wstrndup was added to WINGs only in cvs snapshots.
 			Replace it with something else(reported by jmmv)
 
 03-Jun-2003 17:37  [wdm.1.24] fix compile/link flag
 			results of get-wings-flags changed. update etc/
 			Howto.conf (actual only for my personal computer :) )
 
 01-Jun-2003 12:00  [wdm.1.24] prepare for release
 			update NEWS, change version in configure.ac
 
 
 To generate a diff of this commit:
 cvs rdiff -r1.32 -r1.33 pkgsrc/x11/wdm/Makefile
 cvs rdiff -r1.6 -r1.7 pkgsrc/x11/wdm/PLIST
 cvs rdiff -r1.7 -r1.8 pkgsrc/x11/wdm/distinfo
 cvs rdiff -r1.2 -r1.3 pkgsrc/x11/wdm/files/wdm.sh
 cvs rdiff -r1.4 -r1.5 pkgsrc/x11/wdm/patches/patch-aa
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.