Subject: Re: pkg/34520: wrong path to perl in /usr/pkg/sbin/findsmb
To: None <ansgar@2006.43-1.org, jlam@NetBSD.org, gnats-admin@NetBSD.org,>
From: Kouichirou Hiratsuka <hira@NetBSD.org>
List: pkgsrc-bugs
Date: 09/20/2006 19:53:53
Hello,

At Thu, 14 Sep 2006 02:35:00 +0000 (UTC),
ansgar@2006.43-1.org wrote:
> 
> >Number:         34520
> >Category:       pkg
> >Synopsis:       wrong path to perl in /usr/pkg/bin/findsmb
> >Confidential:   no
> >Severity:       serious
> >Priority:       medium
> >Responsible:    pkg-manager
> >State:          open
> >Class:          sw-bug
> >Submitter-Id:   net
> >Arrival-Date:   Thu Sep 14 02:35:00 +0000 2006
> >Originator:     Ansgar Burchardt
> >Release:        NetBSD 4.99.1
> >Environment:
> System: NetBSD shayolghul.local 4.99.1 NetBSD 4.99.1 (SHAYOLGHUL) #9: Tue Aug 29 22:14:39 CEST 2006 ansgar@shayolghul.local:/home/ansgar/netbsd-current/src/sys/arch/i386/compile/SHAYOLGHUL i386
> Architecture: i386
> Machine: i386
> >Description:
> 	The first line of findsmb is
> 		#!/usr/pkgsrc/net/samba/work/.tools/bin/perl
> >How-To-Repeat:
> 	Install samba
> 	head -n 1 /usr/pkg/sbin/findsmb
> 
> >Fix:
> 
> Unknown
> 

How about this patch?

best regards.
--
 Kouichirou Hiratsuka
   hira@NetBSD.org

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/net/samba/Makefile,v
retrieving revision 1.163
diff -u -r1.163 Makefile
--- Makefile	14 Sep 2006 16:17:43 -0000	1.163
+++ Makefile	20 Sep 2006 10:26:26 -0000
@@ -3,7 +3,7 @@
 .include "Makefile.mirrors"
 
 DISTNAME=		samba-3.0.22
-PKGREVISION=		2
+PKGREVISION=		3
 CATEGORIES=		net
 MASTER_SITES=		${SAMBA_MIRRORS:=old-versions/}
 DIST_SUBDIR=		${DISTNAME}
@@ -82,6 +82,11 @@
 #
 USE_TOOLS+=		mktemp
 
+# findsmb uses perl
+#
+USE_TOOLS+=		perl:run
+REPLACE_PERL=		source/script/findsmb.in
+
 .if !defined(PWD_MKDB)
 PWD_MKDB!=	${TYPE} pwd_mkdb 2>&1 | \
 		${AWK} '/not found/ { print "pwd_mkdb"; exit } { print $$3 }'