Subject: pkg/34543: nn makefile (ymakefile) is broken
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <bsd@allegory.demon.co.uk>
List: pkgsrc-bugs
Date: 09/17/2006 10:10:00 
>Number:         34543
>Category:       pkg
>Synopsis:       nn makefile (ymakefile) is broken
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 17 10:10:00 +0000 2006
>Originator:     Bob Kemp
>Release:        NetBSD 3.99.21
>Organization:
>Environment:
	
	
System: NetBSD tenebres.loc 3.99.21 NetBSD 3.99.21 (TENEBRES) #0: Sat Jul 1 17:11:20 BST 2006 rob@tenebres.loc:/altroot/sys/arch/i386/compile/TENEBRES i386
Architecture: i386
Machine: i386
>Description:
	The makefile, called ymakefile, has leading spaces instead of tabs.
	As a result, make fails as in

	    => Required installed package digest>=20010302: digest-20060826 found
	    ===> Checking for vulnerabilities in nn-6.6.5
	    => Checksum SHA1 OK for nn-6.6.5.tar.Z
	    => Checksum RMD160 OK for nn-6.6.5.tar.Z
	    ===> Building for nn-6.6.5
	    /usr/bin/make   -f ymakefile all
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 19: Need an operator
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 20: Need an operator
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 22: Need an operator
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 23: Need an operator
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 25: Need an operator
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 27: Need an operator
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 29: Need an operator
	    make: "/usr/pkgsrc/news/nn/work/nn-6.6.5/ymakefile" line 31: Need an operator

>How-To-Repeat:
	cd /usr/pkgsrc/news/nn
	make

>Fix:
	In work/nn-6.6.5/Makefile there is a rule to create ymakefile.
	Changing the sed cmd to be less restrictive should fix it, I think.
	On line 63, it reads

	    -e 's/^        /^I/

	where ^I is (of course) a literal tab in the file
	but perhaps it should read

	    -e 's/^  */^I/

	so that any sequence of leading spaces becomes a tab.
	In effect, that's what I did in vi.

>Unformatted: