Subject: Re: pkg/34185 (games/kdegames3 3.5.4 Solaris10)
To: None <solaris-pkg-people@NetBSD.org, gnats-admin@netbsd.org,>
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
List: pkgsrc-bugs
Date: 08/16/2006 09:30:02
The following reply was made to PR pkg/34185; it has been noted by GNATS.
From: Gilles Dauphin <Gilles.Dauphin@enst.fr>
To: solaris-pkg-people@NetBSD.org, markd@NetBSD.org,
gnats-admin@NetBSD.org, ben@NetBSD.org, gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/34185 (games/kdegames3 3.5.4 Solaris10)
Date: Wed, 16 Aug 2006 11:29:43 +0200 (CEST)
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; charset=us-ascii
Content-MD5: Eknn1CCGxoVwmP1VX9mv1A==
> Synopsis: games/kdegames3 3.5.4 Solaris10
>
> Responsible-Changed-From-To: markd->solaris-pkg-people
> Responsible-Changed-By: ben@netbsd.org
> Responsible-Changed-When: Fri, 11 Aug 2006 15:32:59 +0000
> Responsible-Changed-Why:
> Assigned to solaris-pkg-people because this is a solaris PR.
I think it is also a SHELL problem, anyway for easy work
i attach the patch I wish. I think thoses patchs have no impact
on any build (except Solaris ;)
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-aa; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-aa
Content-MD5: IBg+AraWg+4abgL9jdlJDg==
--- kmines/Makefile.in.orig Mon Jul 24 17:08:54 2006
+++ kmines/Makefile.in Fri Aug 11 15:53:18 2006
@@ -902,31 +902,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-ab; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-ab
Content-MD5: /LGpvdR9w31F98IXt5ttLw==
--- kdegames-3.5.4/klickety/Makefile.in.orig Mon Jul 24 17:08:54 2006
+++ kdegames-3.5.4/klickety/Makefile.in Fri Aug 11 16:01:10 2006
@@ -935,31 +935,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-ac; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-ac
Content-MD5: TamcUL+0FMApt6GnXdXcNg==
--- kdegames-3.5.4/kfouleggs/Makefile.in.orig Mon Jul 24 17:08:54 2006
+++ kdegames-3.5.4/kfouleggs/Makefile.in Fri Aug 11 16:04:33 2006
@@ -959,31 +959,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000
Content-Type: TEXT/plain; name=patch-ad; charset=us-ascii; x-unix-mode=0644
Content-Description: patch-ad
Content-MD5: FyA4lIdtk7/EYV9OIHmwlA==
--- kdegames-3.5.4/ksirtet/ksirtet/Makefile.in.orig Mon Jul 24 17:08:56 2006
+++ kdegames-3.5.4/ksirtet/ksirtet/Makefile.in Fri Aug 11 16:10:23 2006
@@ -871,31 +871,31 @@
install-exec-hook:
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
- && chmod 750 $(DESTHIGHSCORES)) \
+ && ( (mkdir -p $(DESTHIGHSCORES) && chown $(highscore_user):$(highscore_group) $(DESTHIGHSCORES) \
+ && chmod 750 $(DESTHIGHSCORES) ) \
|| echo "Error: Could not create the highscore directory with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((chown $(highscore_user):$(highscore_group) $(DESTBIN)) \
+ && ( (chown $(highscore_user):$(highscore_group) $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test ${setgid} = true \
- && ((chmod 2755 $(DESTBIN)) \
+ && ( (chmod 2755 $(DESTBIN) ) \
|| echo "Error: Could not install the game with correct permissions !!" \
- )) || true
+ ) ) || true
@(test x$(HIGHSCORE_DIRECTORY) != x \
- && ((touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
- && chmod 0660 $(DESTSCORES)) \
+ && ( (touch $(DESTSCORES) && chown $(highscore_user):$(highscore_group) $(DESTSCORES) \
+ && chmod 0660 $(DESTSCORES) ) \
|| echo "Error: Could not create system-wide highscore file with correct permissions !!" \
- )) || true
+ ) ) || true
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
.NOEXPORT:
--Charm_of_Finches_390_000--