Subject: pkg/28609: mail/distribute assumes existence of _PATH_SENDMAIL, strsep(), install
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: None <georg.schwarz@freenet.de>
List: pkgsrc-bugs
Date: 12/11/2004 18:06:00
>Number:         28609
>Category:       pkg
>Synopsis:       mail/distribute assumes existence of _PATH_SENDMAIL, strsep(), install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 11 18:06:00 +0000 2004
>Originator:     Georg Schwarz
>Release:        current pkgsrc
>Organization:
>Environment:
IRIX lorenz 5.3 08031225 IP20 mips
>Description:
- mail/distribute's setup assumes strsep() exists on the respective system.
- patch-ab assumes _PATH_SENDMAIL is defined.
- Makefile assumes that install is BSD-compatible.
>How-To-Repeat:

>Fix:
- the following patch to Makefile works for IRIX 5 (maybe other OSes also need it), but admittingly the use of DEFAULTCONFIG here is somewhat a hack; maybe passing CFLAGS would be nicer.

--- Makefile.orig       2004-12-11 18:06:37.000000000 +0100
+++ Makefile    2004-12-11 18:18:18.000000000 +0100
@@ -40,6 +40,11 @@
                INSTALL="${INSTALL}" \
                INSTALL_MAN="${INSTALL_MAN}"
 
+.include "../../mk/bsd.prefs.mk"
+.if !empty(LOWER_OPSYS:Mirix5*)
+MAKE_FLAGS+=   "DEFAULTCONFIG=-DSTRSEP_MISSING"
+.endif
+
 pre-build:
        ${TOUCH} ${WRKSRC}/logging.h ${WRKSRC}/strsep.c

moreover, it is necessary to patch strutil.c to add #include <string.h> in order for strlen() to be known.

- remove patch-ab (why is it there?)
- comment out the INSTALL= line in Makefile.
Maybe in addition it is necessary to change INSTALL="${INSTALL}" into INSTALL="${INSTALL} -c" in the toplevel Makefile.