Re: port-vax/57839

["Jan-Benedict Glaw via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR port-vax/57839; it has been noted by GNATS.

From: Jan-Benedict Glaw <jbglaw%lug-owl.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: port-vax/57839
Date: Sun, 8 Nov 2026 08:44:45 +0100

 --whbJPoPwx1YUiGt1
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hi!
 
 With the following patch applied, I can sucessfully run this test
 case:
 
 vax-template# cd /usr/tests/lib/libc/sys && atf-run t_lwp_create
 
 Content-Type: application/X-atf-tps; version=3D"3"
 
 info: atf.version, Automated Testing Framework 0.20 (atf-0.20)
 info: tests.root, /usr/tests/lib/libc/sys
 info: time.start, Sun Nov 8 07:32:08 UTC 2026
 info: uname.sysname, NetBSD
 info: uname.nodename, vax-template.classiccmp
 info: uname.release, 11.99.9
 info: uname.version, NetBSD 11.99.9 (GENERIC) #0: Wed Oct 28 09:49:53 UTC 2=
 026 mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/vax/compile/GENERIC
 info: uname.machine, vax
 info: env, ENV=3D/root/.shrc
 info: env, BLOCKSIZE=3D1k
 info: env, PWD=3D/usr/tests/lib/libc/sys
 info: env, MAIL=3D/var/mail/root
 info: env, HOME=3D/root
 info: env, PATH=3D/sbin:/usr/sbin:/bin:/usr/bin:/usr/pkg/sbin:/usr/pkg/bin:=
 /usr/games:/usr/X11R7/bin:/usr/local/sbin:/usr/local/bin
 info: env, HOST=3Dvax-template.classiccmp
 info: env, SSH_CONNECTION=3D10.234.0.1 54068 10.234.2.7 22
 info: env, SSH_TTY=3D/dev/pts/0
 info: env, TERM=3Dscreen5
 info: env, OLDPWD=3D/root
 info: env, USER=3Droot
 info: env, SSH_CLIENT=3D10.234.0.1 54068 22
 info: env, PKG_PATH=3Dhttp://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/vax/=
 10.0_2022Q4/All
 info: env, LOGNAME=3Droot
 info: env, SHELL=3D/bin/sh
 tps-count: 1
 tp-start: 1794123148.564015, t_lwp_create, 6
 tc-start: 1794123148.584015, lwp_create_bad_lid_ptr
 tc-end: 1794123150.504058, lwp_create_bad_lid_ptr, passed
 tc-start: 1794123150.574059, lwp_create_generic_fail_no_uc_cpu
 tc-end: 1794123151.524081, lwp_create_generic_fail_no_uc_cpu, passed
 tc-start: 1794123151.584082, lwp_create_vax_fail_psl_0
 tc-end: 1794123152.574104, lwp_create_vax_fail_psl_0, passed
 tc-start: 1794123152.644105, lwp_create_vax_fail_psl_1
 tc-end: 1794123153.624127, lwp_create_vax_fail_psl_1, passed
 tc-start: 1794123153.694129, lwp_create_vax_fail_psl_cm
 tc-end: 1794123154.504147, lwp_create_vax_fail_psl_cm, passed
 tc-start: 1794123154.594149, lwp_create_works
 tc-end: 1794123155.574171, lwp_create_works, passed
 tp-end: 1794123155.644172, t_lwp_create
 info: time.end, Sun Nov 8 07:32:39 UTC 2026
 vax-template#=20
 
 =2E..without crashing, that is.
 
 root@VPS2264-jenkins-node1:/var/cache/git/buildhelpers/patches [master] # c=
 at generic-netbsd--jbglaw-pr57839-enable-DIAGNOSTIC.patch generic-netbsd--j=
 bglaw-pr57839-lwp-free-pcb.patch=20
 diff --git a/distrib/vax/miniroot/Makefile.inc b/distrib/vax/miniroot/Makef=
 ile.inc
 index 37fbd138a3c1..f272794ee7e0 100644
 --- a/distrib/vax/miniroot/Makefile.inc
 +++ b/distrib/vax/miniroot/Makefile.inc
 @@ -1,6 +1,6 @@
  # $NetBSD: Makefile.inc,v 1.25 2017/01/24 18:04:05 christos Exp $
 =20
 -IMAGESIZE=3D     8m
 +IMAGESIZE=3D     10m
  MAKEFS_FLAGS+=3D -o density=3D3k
  IMAGEENDIAN=3D   le
  MAKEDEVTARGETS=3D        all ipty
 diff --git a/sys/arch/vax/conf/GENERIC b/sys/arch/vax/conf/GENERIC
 index b9955a0e5f0f..04a97e03fb72 100644
 --- a/sys/arch/vax/conf/GENERIC
 +++ b/sys/arch/vax/conf/GENERIC
 @@ -51,7 +51,7 @@ makeoptions   DEBUG=3D"-g"
  options        DDB
  options        DDB_HISTORY_SIZE=3D512    # enable history editing in DDB
  options        KTRACE
 -#options       DIAGNOSTIC
 +options        DIAGNOSTIC
  #options       DEBUG
  #options       PMAPDEBUG
  #options       TRAPDEBUG
 diff --git a/sys/arch/vax/vax/vm_machdep.c b/sys/arch/vax/vax/vm_machdep.c
 index fe138a16c2f4..5c2b9855f675 100644
 --- a/sys/arch/vax/vax/vm_machdep.c
 +++ b/sys/arch/vax/vax/vm_machdep.c
 @@ -175,8 +175,15 @@ void
  cpu_lwp_free(struct lwp *l, int proc)
  {
 =20
 -       (void)l;
         (void)proc;
 +
 +       /*
 +        * Unlink the PCB here, before the u-area holding it is freed. THis=
  is
 +        * only needed for LWPs than never ran (due to errors while creating
 +        * them) as in all other cases, mi_switch() will do the job.
 +        */
 +       if (l !=3D curlwp)
 +               pmap_deactivate(l);
  }
 =20
  void
 
 
 
 I've stored it as two patches: One enabling DIAGNOSTIC (and sizing up
 the miniroot fs as it wouldn't fit otherwise), the second part is the
 actual fix.
 
 
 MfG, JBG
 
 --=20
 
 --whbJPoPwx1YUiGt1
 Content-Type: application/pgp-signature; name="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 
 iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCavAoagAKCRAdvV51g5nh
 uz/WAJ4pcg6QmKqdEzKqkKu73uCm1DEMvACbBXJAgJ+Y5FQqFbxf6n5sXfRz9Cw=
 =bBdj
 -----END PGP SIGNATURE-----
 
 --whbJPoPwx1YUiGt1--