PR/60413 CVS commit: src/lib/libc/citrus/modules

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR lib/60413; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/60413 CVS commit: src/lib/libc/citrus/modules
Date: Sun, 5 Jul 2026 20:40:04 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Jul  5 20:40:04 UTC 2026
 
 Modified Files:
 	src/lib/libc/citrus/modules: citrus_viqr.c
 
 Log Message:
 iconv VIQR: Fix use-after-free during destruction.
 
 PR lib/59019: various iconv issues
 
 Prompted by investigating:
 
 PR lib/60413: iconv_samples test crashes on sparc*
 
 Fixed in FreeBSD back in 2022, and I confirmed -Wuse-after-free catches
 this for us too, but we're not using it -- maybe we should:
 
 commit 8f27c9d14a559f33aa7fc3245f841f7ce52fadd5
 Author: John Baldwin <jhb%FreeBSD.org@localhost>
 Date:   Mon Oct 3 16:10:43 2022 -0700
 
     libiconv VIQR: Fix a use after free.
 
     Use TAILQ_FOREACH_SAFE to walk to list of children mnemonics to
     free
     them instead of TAILQ_FOREACH.
 
     Reviewed by:    emaste
     Reported by:    GCC 12 -Wuse-after-free
     Differential Revision:  https://reviews.freebsd.org/D36821
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 src/lib/libc/citrus/modules/citrus_viqr.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.