Re: bin/57179 (occasional pkg_add core dumps)

[riastradh%NetBSD.org@localhost]

Synopsis: occasional pkg_add core dumps

State-Changed-From-To: closed->open
State-Changed-By: riastradh%NetBSD.org@localhost
State-Changed-When: Wed, 08 Apr 2026 17:05:44 +0000
State-Changed-Why:
It looks like the fix for this never got applied to pkgsrc libfetch?

>From a pkg_install I built in January (based on probably ~Decemberish
sources), I got a similar crash, and when I look at the changes to
pkgsrc/net/libfetch/files/common.c, I don't see any of the changes
christos@ put in to fix this PR -- nothing changed in common.c between
2016 and now except my early-2024 change to neable HTTPS certificate
validation by default.

[1]   Segmentation fault (core dumped) ${TOOL_PKG_ADD:-pkg_add} -v -f -I -P "${mnt}" ...
$ gdb .../pkg_add pkg_add.core
...
Core was generated by `pkg_add'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000070951676b52b in strcmp () from /usr/lib/libc.so.12
(gdb) bt
#0  0x000070951676b52b in strcmp () from /usr/lib/libc.so.12
#1  0x0000000168a30bd1 in fetch_cache_put (conn=0x7095181a9460,
    closecb=0x168a31451 <fetch_close>) at common.c:417
#2  0x0000000168a331ff in http_closefn (v=0x709516ec8df0) at http.c:337
#3  0x0000000168a31ddf in fetchIO_close (f=0x7095172b1e80) at common.c:1051
#4  0x0000000168a0ce02 in fetch_archive_close (a=<optimized out>,
    client_data=0x709517356040) at pkg_io.c:138
#5  0x0000709517477a2f in client_close_proxy (self=0x709517248e40)
    at /usr/src/9/external/bsd/libarchive/dist/libarchive/archive_read.c:257
#6  0x0000709517477a77 in close_filters (a=<optimized out>)
    at /usr/src/9/external/bsd/libarchive/dist/libarchive/archive_read.c:1009
#7  0x0000709517477af1 in _archive_read_close (_a=0x709518181800)
    at /usr/src/9/external/bsd/libarchive/dist/libarchive/archive_read.c:1069
#8  0x0000709517478775 in _archive_read_free (_a=0x709518181800)
    at /usr/src/9/external/bsd/libarchive/dist/libarchive/archive_read.c:1094
#9  0x0000000168a08a74 in pkg_do (
    pkgpath=pkgpath@entry=0x709517265d80 "perl>=5.42.0<5.43.0",
    mark_automatic=mark_automatic@entry=1, top_level=top_level@entry=0)
    at perform.c:1697
#10 0x0000000168a4450a in install_depend_pkg (
    dep=0x709517265d80 "perl>=5.42.0<5.43.0") at perform.c:1206
#11 check_dependencies (pkg=pkg@entry=0x7095182486c0) at perform.c:1246
#12 0x0000000168a098cb in pkg_do (
    1.647nb1", mark_automatic=mark_automatic@entry=1, top_level=top_level@entry=0) at perform.c:1626
#13 0x0000000168a4450a in install_depend_pkg (dep=0x7095177fd840 "p5-DBI>=1.647nb1") at perform.c:1206
#14 check_dependencies (pkg=pkg@entry=0x709518248440) at perform.c:1246
#15 0x0000000168a098cb in pkg_do (pkgpath=pkgpath@entry=0x7095177b5e20 "p5-DBD-SQLite>=0", mark_automatic=mark_automatic@entry=1, top_level=top_level@entry=0) at perform.c:1626
#16 0x0000000168a4450a in install_depend_pkg (dep=0x7095177b5e20 "p5-DBD-SQLite>=0") at perform.c:1206
#17 check_dependencies (pkg=pkg@entry=0x709518247b80) at perform.c:1246
#18 0x0000000168a098cb in pkg_do (pkgpath=pkgpath@entry=0x70951810c4c0 "git-perlscripts>=2.47.1", mark_automatic=mark_automatic@entry=1, top_level=top_level@entry=0) at perform.c:1626
#19 0x0000000168a4450a in install_depend_pkg (dep=0x70951810c4c0 "git-perlscripts>=2.47.1") at perform.c:1206
#20 check_dependencies (pkg=pkg@entry=0x709518246000) at perform.c:1246
#21 0x0000000168a098cb in pkg_do (pkgpath=<optimized out>, mark_automatic=0, top_level=top_level@entry=1) at perform.c:1626
#22 0x0000000168a09cda in pkg_perform (pkgs=0x7f7fff1749e0) at perform.c:1713
#23 0x0000000168a4497a in main (argc=<optimized out>, argv=<optimized out>) at main.c:204