Re: bin/60016 (make(1) tests failing since sjg MaybeSubMake changes)

["Simon J. Gerraty via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR bin/60016; it has been noted by GNATS.

From: "Simon J. Gerraty" <sjg%juniper.net@localhost>
To: Christos Zoulas <christos%zoulas.com@localhost>
Cc: <gnats-bugs%netbsd.org@localhost>, <gnats-admin%netbsd.org@localhost>,
        <netbsd-bugs%netbsd.org@localhost>, <campbell+netbsd%mumble.net@localhost>,
        "rillig%netbsd.org@localhost"
	<rillig%netbsd.org@localhost>, <sjg%juniper.net@localhost>
Subject: Re: bin/60016 (make(1) tests failing since sjg MaybeSubMake changes)
Date: Sat, 28 Feb 2026 14:53:52 -0800

 Christos Zoulas <christos%zoulas.com@localhost> wrote:
 
 > Index: job-output.mk
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /cvsroot/src/usr.bin/make/unit-tests/job-output.mk,v
 > retrieving revision 1.2
 > diff -u -u -r1.2 job-output.mk
 > --- job-output.mk       13 Jun 2025 06:13:20 -0000      1.2
 > +++ job-output.mk       28 Feb 2026 20:24:01 -0000
 > @@ -28,7 +28,7 @@
 >  # expect: This is stderr.
 >  # expect: only stderr:
 >  # expect: end stdout-and-stderr
 > -stdout-and-stderr:
 > +stdout-and-stderr: .MAKE
 
 This fixes it?
 Interesting.
 
 I would not expect .MAKE to be needed, since ${MAKE} below *should* be
 recognized, and cause OP_SUBMAKE to be set.
 
 Adding .MAKEFLAGS: -dg2 at the end we see
 
 # all, unmade, type OP_DEPENDS|OP_PHONY|OP_HAS_COMMANDS, flags none
 # empty-lines, unmade, type OP_DEPENDS|OP_PHONY|OP_HAS_COMMANDS, flags non=
 e
 # stdout-and-stderr, made, type OP_DEPENDS|OP_SUBMAKE|OP_HAS_COMMANDS|OP_D=
 EPS_FOUND|OP_MARK, flags REMAKE|DONE_WAIT|DONE_ALLSRC|DONE_SUBMAKE|DONECYC=
 LE
 #
 
 but that's on a box where the test passes.
 If you have netbsd-i386 can you see what you get for
 .MAKEFLAGS: -dg2 and without the .MAKE above
 
 Thanks!
 --sjg