Re: bin/59973: sntp core dump on NetBSD/evbppc

["Michael van Elst via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR bin/59973; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/59973: sntp core dump on NetBSD/evbppc
Date: Sun, 8 Feb 2026 00:13:29 -0000 (UTC)

 gnats-admin%NetBSD.org@localhost ("jmcneill%invisible.ca@localhost via gnats") writes:
 
 >nintendo# sntp time.nrc.ca
 >sntp 4.2.8p18-o Fri Jan 30 11:27:35 UTC 2026 (1)
 >kod_init_kod_db(): Cannot open KoD db file /var/db/ntp-kod: No such file or directory
 >[1]   Segmentation fault (core dumped) sntp time.nrc.ca
 
 
 For some reason, a NULL pointer check was dropped with the last
 NTP update.
 
 Restoring the check helps.
 
 Index: external/bsd/ntp/dist/include/ntp_lists.h
 ===================================================================
 RCS file: /cvsroot/src/external/bsd/ntp/dist/include/ntp_lists.h,v
 retrieving revision 1.8
 diff -p -u -r1.8 ntp_lists.h
 --- external/bsd/ntp/dist/include/ntp_lists.h   1 Oct 2024 20:59:51 -0000      1.8
 +++ external/bsd/ntp/dist/include/ntp_lists.h   8 Feb 2026 00:12:50 -0000
 @@ -155,7 +155,7 @@ do {                                                       \
                                                                 \
         ppentry = &(listhead);                                  \
         while (TRUE) {                                          \
 -               if (beforecur) {                                \
 +               if (NULL == *ppentry || (beforecur)) {          \
                         (pentry)->nextlink = *ppentry;          \
                         *ppentry = (pentry);                    \
                         break;                                  \