Re: xsrc/59952: xsetwallpaper: server/client endian mismatch

["Valery Ushakov via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR xsrc/59952; it has been noted by GNATS.

From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: xsrc/59952: xsetwallpaper: server/client endian mismatch
Date: Wed, 4 Feb 2026 13:28:04 +0300

 On Wed, Feb 04, 2026 at 01:05:01 +0000, Adrian Chadd via gnats wrote:
 
 >  Well, my next diff is handling servers that aren't ARGB. :-P
 
 I thought about that too, but that's not a rabbit hole I currently
 have enough time for.
 
 
 >  I'm tempted to lean in here and not bswap at all but let x11 do it.
 >  I believe that's what the API is meant to encourage.
 
 I'd rather we handle it explicitly in the xsetwallpaper code.  We
 almost always need to shuffle the bytes anyway, so it's less cognitive
 load on the reader to shuffle it to the order the server wants, than
 to shuffle them into some other order and then let some other code
 shuffle them some more (doing the work twice, not that xsetwallpaper
 is perforamce critical code, as Michael said).
 
 Could you kindly make your extended non-argb patch to go down that
 direction?
 
 PS: From a private chat with Jared:
 
 | feel free to commit the fix
 
 
 -uwe