Re: kern/59681: npf: missing locking around inpcb_lookup in uid/gid checks

["Emmanuel Nyarko via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59681; it has been noted by GNATS.

From: Emmanuel Nyarko <emmankoko519%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/59681: npf: missing locking around inpcb_lookup in uid/gid
 checks
Date: Wed, 1 Oct 2025 13:45:58 +0000

 Hi, 
 
 --- sys/net/npf/npf_socket.c	2 Jun 2025 13:19:27 -0000	1.3
 +++ sys/net/npf/npf_socket.c	1 Oct 2025 13:29:20 -0000
 @@ -92,6 +92,7 @@
  
      KASSERT(npf_iscached(npc, NPC_IP46));
  
 +    mutex_enter(softnet_lock);
      if (npf_iscached(npc, NPC_IP4)) {
          so = npf_ip_socket(npc, dir);
  #if defined(INET6)
 @@ -104,6 +105,8 @@
          return -1;
  
      *rid = get_rid(so->so_cred);
 +    mutex_exit(softnet_lock);
 +
      return 0;
  }
 
 
 should be fine?
 
 Emmanuel