Re: bin/59646: sh: generating optinit.h depends on host environment

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Thu, 11 Sep 2025 11:01:34 +0900
    From:        Ryota Ozaki <ozaki-r%netbsd.org@localhost>
    Message-ID:  <CAKrYomhax0=ghj7_7mb9Pz9Hj78navHZk-yfSwsr9fL=haC0Mw%mail.gmail.com@localhost>

  | I'm sorry for not describing the details.  The issue occurs with
  | building netbsd-10

No problem, that was kind of obvious, but the "any" in the Environment
of the PR was not strictly correct.

  | I just thought that as sed and awk are in tools :)

There are, unfortunately, several different dialects of those, and
the build scripts sometimes use things in the way we expect them to
work, rather than only in a way that is certain to work the same
everywhere.   In general that's true of all of the tools, or we wouldn't
bother with them, we'd just use the build host's version.

  | And, I've just noticed that mkoptions.sh v1.8 changed the options of sort.

Yes, that's what uwe@ pointed out in the first response to the PR.

  | So I think building on -11 or -current doesn't have the issue.

Its not what we are building on which matters, but what we are building,
and yes, that's what Christos' change in 1.8 of that file was about, so
(since it happened before -11 was branched) -11 and HEAD builds should not
see this issue.

I have already fixed (in HEAD) option.list to only use tab in the
relevant places (not 100% sure that will be enough to avoid the issue,
as in some places there might be more than one tab, and if they're not
being ignored as white space, that would still, I think, alter the
resulting ordered list.

I will get that change pulled up to -11 (trivial) and to (-10) easy
enough, though it might require a patch, but there is only one new
option since -10, and that one isn't "normal" (like for example -c
also isn't) so is in that file only as a comment - including the comment
in -10's version would harm nothing (do nothing).   -9 might need to
be done via a patch, as there is a real new option ("login") since -9's
version, which we wouldn't want to make apparently exist in -9 (just
adding the line in this file is all that is needed to make a new option
exist, but without code somewhere else in the shell to use the thing,
it is just an empty promise.)

I will also arrange for mkoptions.sh to be updated to be the same as
it is in HEAD in all versions (-11 already is, so nothing to do for that one).
This is just a script used in building sh there's no reason it needs to
be different in the different versions, what it does is the same for all
of them, and has been for a long time now (just its code has been improved
over time).

Thanks for the PR, or this might not have ever been noticed.

kre