Re: kern/59576: viogpu causes race condition between pckbd_enable and pckbd_set_leds

["Martin Husemann via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59576; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/59576: viogpu causes race condition between pckbd_enable
 and pckbd_set_leds
Date: Tue, 12 Aug 2025 08:44:12 +0200

 On Wed, Aug 06, 2025 at 08:20:00AM +0000, alex14fr%gmail.com@localhost wrote:
 > - pckbd_enable uses pckbport_poll_cmd to send KBC_ENABLE command
 > - pckbcintr fires, causing a call to pckbd_set_leds
 > - pckbd_set_leds sends a KBC_MODEIND keyboard command, waits for acknowledgement but eats the acknowledgement of KBC_ENABLE that should have been read by pckbd_enable/pckbport_poll_cmd
 
 Wouldn't it be better to make pckbd_set_leds() return immediately if
 sc->sc_enabled is not yet set?
 
 Could you test that?
 
 Martin