re: bin/59504: dhcpd crashes on arm64eb regularly, now an ASAN enabled one has some details

[matthew green <mrg%eterna23.net@localhost>]

i had another ASAN crash, but it didn't have useful info, and i noticed
that it wasn't applying sanitizer flags to a bunch of the private libs.

now i fixed that (separate PR to be filed), reinstalled dhpcd with this
and i now have a better result.  see below.  i have not yet analyzed
what it means, but i wanted to update anyway.


.mrg.


=================================================================
==20049==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xfffff5e1d100 at pc 0xfffffb41009c bp 0xffffedbb5090 sp 0xffffedbb50f8
WRITE of size 64 at 0xfffff5e1d100 thread T11
    #0 0xfffffb410098 in __interceptor_memset /usr/10/src/external/gpl3/gcc/dist/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:780
    #1 0x1b6774 in option_cache_allocate /usr/10/src/external/mpl/dhcp/lib/common/../../dist/common/alloc.c:652
    #2 0x127a28 in ack_lease /usr/10/src/external/mpl/dhcp/bin/server/../../dist/server/dhcp.c:3331
    #3 0x12d1b0 in dhcprequest /usr/10/src/external/mpl/dhcp/bin/server/../../dist/server/dhcp.c:768
    #4 0x12e6e8 in dhcp /usr/10/src/external/mpl/dhcp/bin/server/../../dist/server/dhcp.c:261
    #5 0x1d495c in do_packet /usr/10/src/external/mpl/dhcp/lib/common/../../dist/common/options.c:4107
    #6 0x1a43b0 in got_one /usr/10/src/external/mpl/dhcp/lib/common/../../dist/common/discover.c:1159
    #7 0x2120f0 in omapi_iscsock_cb /usr/10/src/external/mpl/dhcp/lib/omapip/../../dist/omapip/dispatch.c:172
    #8 0x57b170 in internal_fdwatch_read /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3208
    #9 0x57b170 in dispatch_recv /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:2718
    #10 0x57b170 in process_fd /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3279
    #11 0x57b170 in process_fds /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3326
    #12 0x57b170 in netthread /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3613
    #13 0x5dcf50 in isc__trampoline_run /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/trampoline.c:215
    #14 0xfffffb35db50 in pthread__create_tramp /usr/10/src/lib/libpthread/pthread.c:595
    #15 0xfffffa9f9528 in __mknod50 ??:?

0xfffff5e1d100 is located 0 bytes to the right of 48-byte region [0xfffff5e1d0d0,0xfffff5e1d100)
allocated by thread T11 here:
    #0 0xfffffb40e468 in calloc /usr/10/src/external/gpl3/gcc/dist/libsanitizer/asan/asan_malloc_linux.cc:153 (discriminator 2)
    #1 0x21b4ac in dmalloc /usr/10/src/external/mpl/dhcp/lib/omapip/../../dist/omapip/alloc.c:76
    #2 0x1b6170 in expression_allocate /usr/10/src/external/mpl/dhcp/lib/common/../../dist/common/alloc.c:443
    #3 0x1bd570 in make_const_data /usr/10/src/external/mpl/dhcp/lib/common/../../dist/common/tree.c:230
    #4 0x129350 in ack_lease /usr/10/src/external/mpl/dhcp/bin/server/../../dist/server/dhcp.c:3332
    #5 0x12d1b0 in dhcprequest /usr/10/src/external/mpl/dhcp/bin/server/../../dist/server/dhcp.c:768
    #6 0x12e6e8 in dhcp /usr/10/src/external/mpl/dhcp/bin/server/../../dist/server/dhcp.c:261
    #7 0x1d495c in do_packet /usr/10/src/external/mpl/dhcp/lib/common/../../dist/common/options.c:4107
    #8 0x1a43b0 in got_one /usr/10/src/external/mpl/dhcp/lib/common/../../dist/common/discover.c:1159
    #9 0x2120f0 in omapi_iscsock_cb /usr/10/src/external/mpl/dhcp/lib/omapip/../../dist/omapip/dispatch.c:172
    #10 0x57b170 in internal_fdwatch_read /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3208
    #11 0x57b170 in dispatch_recv /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:2718
    #12 0x57b170 in process_fd /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3279
    #13 0x57b170 in process_fds /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3326
    #14 0x57b170 in netthread /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3613
    #15 0x5dcf50 in isc__trampoline_run /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/trampoline.c:215
    #16 0xfffffb35db50 in pthread__create_tramp /usr/10/src/lib/libpthread/pthread.c:595
    #17 0xfffffa9f9528 in __mknod50 ??:?

Thread T11 created by T0 here:
    #0 0xfffffb450ea0 in __interceptor_pthread_create /usr/10/src/external/gpl3/gcc/dist/libsanitizer/asan/asan_interceptors.cc:213
    #1 0x5b143c in isc_thread_create /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/pthreads/thread.c:83
    #2 0x57ea4c in isc_socketmgr_create2 /usr/10/src/external/mpl/dhcp/bind/lib/libisc/../../dist/lib/isc/unix/socket.c:3918
    #3 0x2113e4 in dhcp_context_create /usr/10/src/external/mpl/dhcp/lib/omapip/../../dist/omapip/isclib.c:228
    #4 0x5fc7f0 in main /usr/10/src/external/mpl/dhcp/bin/server/../../dist/server/dhcpd.c:664
    #5 0x113f14 in ___start /usr/10/src/lib/csu/common/crt0-common.c:350
    #6 0xfffffbed0b0c in _rtld_start :?

SUMMARY: AddressSanitizer: heap-buffer-overflow /usr/10/src/external/gpl3/gcc/dist/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:780 in __interceptor_memset
Shadow bytes around the buggy address:
  0x200ffebc39d0: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fd
  0x200ffebc39e0: fa fa 00 00 00 00 00 00 fa fa 00 00 00 00 00 00
  0x200ffebc39f0: fa fa 00 00 00 00 00 00 fa fa 00 00 00 00 00 00
  0x200ffebc3a00: fa fa 00 00 00 00 00 00 fa fa 00 00 00 00 00 00
  0x200ffebc3a10: fa fa 00 00 00 00 00 00 fa fa 00 00 00 00 00 00
=>0x200ffebc3a20:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ffebc3a30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ffebc3a40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ffebc3a50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ffebc3a60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ffebc3a70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Arra cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==20049==ABORTING