Re: kern/59498: Add missing POSIX O_CLOFORK flag

["Robert Elz via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59498; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: Ricardo Branco <rbranco%suse.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/59498: Add missing POSIX O_CLOFORK flag
Date: Fri, 11 Jul 2025 07:27:42 +0700

     Date:        Thu, 10 Jul 2025 15:13:49 +0200
     From:        Ricardo Branco <rbranco%suse.de@localhost>
     Message-ID:  <330bc7f1-ff17-45c5-b211-6b8cf1844d9d%suse.de@localhost>
 
   | To me it's the most problematic because I had to change a
   | bool field in a struct to u_char,
 
 That, or you could just add a new bool field.   The following
 field is an int, so there's padding between the 2 bool fields
 that start the struct fdfile, and the ff_refcnt field anyway.
 Add a 3rd bool (between ff_allocated and ff_refcnt, so it goes
 into the 2 byte padding space) and I think that means that we
 won't need a kernel revbump for this addition (unless some other
 change elsewhere requires it).
 
   | and also because the dup3()
   | implementation is or was reportedly broken:
 
 dup3() had some changes last year, but that seems like a minor
 issue, and would be unrelated to what you're doing.   What is
 (or was) the problem supposed to be?
 
 kre