Re: kern/59498: Add missing POSIX O_CLOFORK flag

["Robert Elz via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59498; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: Ricardo Branco <rbranco%suse.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/59498: Add missing POSIX O_CLOFORK flag
Date: Wed, 02 Jul 2025 03:32:33 +0700

     Date:        Tue, 1 Jul 2025 21:16:22 +0200
     From:        Ricardo Branco <rbranco%suse.de@localhost>
     Message-ID:  <c1904fad-a790-48e0-aaa3-781e60541686%suse.de@localhost>
 
   | I identified a number of places where FD_CLOEXEC is naively set
   | without ORing with the results from F_GETFD, but first wanted to
   | check whether you want to support this flag at all.
 
 O_CLOFORK (and FD_CLOFORK) - yes certainly, it has to happen, we just
 need to do it a bit carefully, as for a long time (like ever since
 fcntl(F_GETFD) was invented) it has been "known" that the only flag
 at that level was close-on-exec (the only one which belongs to the
 process's open file table, rather that the system's global open file
 table).   So we need to avoid breaking things which currently assume
 that (by fixing them) when this appears - ideally before they break.
 
 kre