NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
bin/59495: umount -v is too verbose; should need -vv (as mount)
>Number: 59495
>Category: bin
>Synopsis: umount -v shows all-or-nothing on unmounting filesystems
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: bin-bug-people
>State: open
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sun Jun 29 22:05:00 +0000 2025
>Originator: greywolf%valentina.serenity.starwolf.com@localhost
>Release: NetBSD 10.1 [built 2025-03-05T11:23:00-0700]
>Organization:
--*greywolf;
>Environment:
System: NetBSD valentina.serenity.starwolf.com 10.1 NetBSD 10.1 (VALENTINA) #3: Sun Jun 29 12:09:29 PDT 2025 root@:/usr/src/sys/arch/amd64/compile/VALENTINA amd64
Architecture: x86_64
Machine: amd64
>Description:
[See my disclaimer for the PR sent before this for "mount -v"].
umount -v seems excessively verbose; in contrast with just showing
what it is unmounting, it is also showing "Trying unmount program..." and
"(no separate unmount program)"; some application of additional
instances of -v would be useful here.
Again, if this is deemed "an egregious hack", I would like to know
the rationale behind all-or-nothing output from umount -v.
Patches attached
>How-To-Repeat:
umount -v {filesystem}
: note the additional output besides simply
: "{dev}: umount from {dir}"
>Fix:
--- umount.c.orig 2025-06-29 14:04:24.334557542 -0700
+++ umount.c 2025-06-29 14:11:05.687333437 -0700
@@ -130,7 +130,7 @@
typelist = makevfslist(optarg);
break;
case 'v':
- verbose = 1;
+ verbose++;
break;
#endif /* !SMALL */
default:
@@ -275,7 +275,7 @@
if (verbose) {
(void)printf("%s: unmount from %s\n", name, mntpt);
/* put this before the test of FAKE */
- if (!raw) {
+ if (!raw && verbose > 1) {
(void)printf("Trying unmount program %s\n",
umountprog);
}
@@ -308,7 +308,7 @@
}
#ifndef SMALL
- if (verbose)
+ if (verbose > 1)
(void)printf("(No separate unmount program.)\n");
#endif
--- umount.8.orig 2025-06-29 15:01:30.930607016 -0700
+++ umount.8 2025-06-29 14:17:56.481070826 -0700
@@ -154,8 +154,9 @@
and
.Tn MFS .
.It Fl v
-Verbose, additional information is printed out as each file system
-is unmounted.
+Verbose mode. List each filesystem as it is unmounted.
+If this flag is specified more than once, additional information is printed out as each
+file system is unmounted.
.El
.Sh FILES
.Bl -tag -width /etc/fstab -compact
Home |
Main Index |
Thread Index |
Old Index