Re: kern/59486: compat_linux should ignore IP_MULTICAST_ALL

["Christoph Badura via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59486; it has been noted by GNATS.

From: Christoph Badura <bad%bsd.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/59486: compat_linux should ignore IP_MULTICAST_ALL
Date: Fri, 27 Jun 2025 10:07:17 +0200

 On Thu, Jun 26, 2025 at 07:40:00PM +0000, mc36%freemail.hu@localhost wrote:
 > diff -crB a/linux_socket.c b/linux_socket.c
 > *** a/linux_socket.c	2021-09-23 08:56:27.000000000 +0200
 > --- b/linux_socket.c	2025-06-26 21:32:40.762049616 +0200
 > ***************
 > *** 1006,1011 ****
 > --- 1006,1013 ----
 >   {
 >   
 >   	switch (lopt) {
 > + 	case LINUX_IP_MULTICAST_ALL:
 > + 		return -2;	/* ignored */
 >   	default:
 >   		return -1;
 >   	}
 
 Isn't this in the wrong places?  level is IPPROTO_IP not IPPROTO_UDP.
 
 Wouldn't it be better to return ENOPROTOOPT?  Because that's what the java
 code expects?  
 
 Also, you're missing the equivalent changes for IPv6.
 
 Could you update your changes to be more complete?
 
 --chris