NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/58674 CVS commit: src/sys/arch/powerpc/stand/mkbootimage



The following reply was made to PR lib/58674; it has been noted by GNATS.

From: "David H. Gutteridge" <gutteridge%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58674 CVS commit: src/sys/arch/powerpc/stand/mkbootimage
Date: Sun, 3 Nov 2024 03:11:25 +0000

 Module Name:	src
 Committed By:	gutteridge
 Date:		Sun Nov  3 03:11:24 UTC 2024
 
 Modified Files:
 	src/sys/arch/powerpc/stand/mkbootimage: mkbootimage.c
 
 Log Message:
 mkbootimage.c: consistently use sa_htobe32(2)
 
 There were 38 calls to sa_htobe32(2) and two to htonl(3), mixed even
 within the same function, with arpa/inet.h not included. (It's unclear
 why this varied, as the original version of this file first checked in
 included this discrepancy.)
 
 Addresses build failure issue on current Linux distros that have a GCC
 with implicit-function-declaration baked in as an error. Build tested
 on Fedora 40.
 
 Issue reported by Jan-Benedict Glaw. Also relevant to PR lib/58674.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.20 -r1.21 \
     src/sys/arch/powerpc/stand/mkbootimage/mkbootimage.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Home | Main Index | Thread Index | Old Index