PR/58674 CVS commit: [netbsd-9] src

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR lib/58674; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58674 CVS commit: [netbsd-9] src
Date: Tue, 15 Oct 2024 18:34:41 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Oct 15 18:34:41 UTC 2024
 
 Modified Files:
 	src/bin/date [netbsd-9]: date.c
 	src/external/gpl2/gmake/dist [netbsd-9]: main.c
 	src/sys/sys [netbsd-9]: signal.h
 	src/usr.bin/sed [netbsd-9]: process.c
 
 Log Message:
 Pull up following revision(s) (requested by kre in ticket #1914):
 
 	bin/date/date.c	(apply patch)
 	usr.bin/sed/process.c: revision 1.54
 	sys/sys/signal.h: revision 1.77
 	sys/sys/signal.h: revision 1.78
 	external/gpl2/gmake/dist/main.c: revision 1.2
 
 PR lib/58674
 
 When building the tools version of sed, treat all wide characters
 as if they occupy just one column for the purposes of sed's 'l'
 command (which it is very unlikely to be used from the tools sed).
 wdwidth() is another XSI function, not necessarily available everywhere.
 
 PR lib/58674
 bsd_signal should only be visible with _NETBSD_SOURCE - it isn't any kind of
 standard function (despite also existing in other systems).
 
 This change inspired by the PR, but doesn't fix it in any way, the tools
 config script for gmake doesn't care if the function is visible in any
 header, merely if present in libc.
 
 PR lib/58674 (not really so much any more)
 Correct previous.
 bsd_signal should only be visible with _NETBSD_SOURCE - it isn't any kind of
 standard function (despite also existing in other systems).
 
 Turns out that it used to be an XSI function, back in the dark ages
 ('twas removed in POSIX issue 7, back in 2008, after being marked
 obsolete in issue 6 (2001)).
 
 So, make it visible to any applications that request a suitable
 X/Open version (and of course, for _NETBSD_SOURCE).
 Still no effect on the issue for the PR.
 
 PR lib/58674
 Hopefully allow the tools gmake to build (everywhere).
 
 Don't use the system bsd_signal() function, even if one is
 defined, use a locally defined one instead.   Note that it
 cannot be declared static (which the code would do) as it
 is possible that system header files might define the function,
 if it exists on the host system, and that prototype would not
 (cannot) be static.
 
 This is a horrible hack, feel free to do something better.
 
 Note: this version of gmake is (currently anyway) used only
 as part of the tools used for building NetBSD - apart from that
 it is used for nothing.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.61.18.1 -r1.61.18.2 src/bin/date/date.c
 cvs rdiff -u -r1.1.1.1 -r1.1.1.1.18.1 src/external/gpl2/gmake/dist/main.c
 cvs rdiff -u -r1.72 -r1.72.16.1 src/sys/sys/signal.h
 cvs rdiff -u -r1.52 -r1.52.18.1 src/usr.bin/sed/process.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.