Re: bin/58581 (ftp(1) should allow specifying header fields in http requests)

[Sunil Nimmagadda <sunil%nimmagadda.net@localhost>]

"RVP via gnats" <gnats-admin%NetBSD.org@localhost> writes:

> The following reply was made to PR bin/58581; it has been noted by GNATS.
>
> From: RVP <rvp%SDF.ORG@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc: Sunil Nimmagadda <sunil%nimmagadda.net@localhost>
> Subject: Re: bin/58581 (ftp(1) should allow specifying header fields in http
>  requests)
> Date: Mon, 30 Sep 2024 08:30:26 +0000 (UTC)
>
>  Some very minor nits, Sunil/Christos:
>  
>  1. In ftp.1, the SYNOPSIS says `-h header' instead of `-H header'.
>  
>      Also, there's a `.' missing before `It Fl' in the DESCRIPTION of that
>      option, so it's now taken to be part of the prev. option, `-g'.
>  
>      And, it should be mentioned that multiple `-H's are allowed.
>  
>  2. In ftp/main.c synopsis() should be updated for `-H'.
>  
>  Thx,
>  
>  -RVP
>  

Thanks, the markup fixes are attached...

diff --git a/usr.bin/ftp/ftp.1 b/usr.bin/ftp/ftp.1
index e703e2e58cd8..4215d22e114f 100644
--- a/usr.bin/ftp/ftp.1
+++ b/usr.bin/ftp/ftp.1
@@ -67,7 +67,7 @@
 .Nm
 .Op Fl 46AadefginpRtVv\&?
 .Op Fl b Ar bufsize
-.Op Fl h Ar header
+.Op Fl H Ar header
 .Op Fl N Ar netrc
 .Op Fl o Ar output
 .Op Fl P Ar port
@@ -224,7 +224,7 @@ or
 proxies.
 .It Fl g
 Disables file name globbing.
-It Fl H Ar header
+.It Fl H Ar header
 Include the provided
 .Ar header
 string as a custom
@@ -232,6 +232,9 @@ string as a custom
 header for an
 .Th HTTP
 request.
+Multiple headers may be specified via
+.Fl H
+option.
 .It Fl i
 Turns off interactive prompting during
 multiple file transfers.
diff --git a/usr.bin/ftp/main.c b/usr.bin/ftp/main.c
index cc862615c50f..3095fe772a10 100644
--- a/usr.bin/ftp/main.c
+++ b/usr.bin/ftp/main.c
@@ -1080,7 +1080,7 @@ synopsis(FILE * stream)
 	const char * progname = getprogname();
 
 	fprintf(stream,
-"usage: %s [-46AadefginpRtVv] [-N NETRC] [-o OUTPUT] [-P PORT] [-q QUITTIME]\n"
+"usage: %s [-46AadefginpRtVv] [-H header] [-N NETRC] [-o OUTPUT] [-P PORT] [-q QUITTIME]\n"
 "           [-r RETRY] [-s SRCADDR] [-T DIR,MAX[,INC]] [-x XFERSIZE]\n"
 "           [[USER@]HOST [PORT]]\n"
 "           [[USER@]HOST:[PATH][/]]\n"