NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/58678: ntpd crashes on sparc64



The following reply was made to PR bin/58678; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Christos Zoulas <christos%zoulas.com@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: bin/58678: ntpd crashes on sparc64
Date: Fri, 20 Sep 2024 13:50:36 +0200

 On Fri, Sep 20, 2024 at 07:37:19AM -0400, Christos Zoulas wrote:
 > Yes I would send it to harlan, but I would prefer that it was done more portably, i.e. arrange for the struct to be always aligned properly so that there are no machine specific ifdefs.
 
 The strust is properly non-padded and aligned with the patch I
 suggested, but the tricks they play to shave off a few bytes if storing
 only an IPv4 address makes things complicated.
 
 The easiest way is to avoid the tricks at all (basically what the patch
 does now for the alignment critical machines, but the code could be simplified
 if that would be done for all).
 
 However, on tiny ram non-alignement-critical machines the tricks save a bit of
 memory, so I left that in place and used the ifdefs.
 
 I would leave that at upstream's choice - this is the minimal intrusive fix.
 
 Martin
 


Home | Main Index | Thread Index | Old Index