toolchain/58682: dtrace is missing sys/types.h

[ondrej%sury.org@localhost]

>Number:         58682
>Category:       toolchain
>Synopsis:       dtrace is missing sys/types.h
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 20 08:15:00 +0000 2024
>Originator:     Ondřej Surý
>Release:        10.0
>Organization:
ISC
>Environment:
NetBSD netbsd-10.home.sury.org 10.0 NetBSD 10.0 (GENERIC) #0: Thu Mar 28 08:33:33 UTC 2024  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
>Description:
dtrace seems to be missing `#include <sys/types.h>` internally
>How-To-Repeat:
Any probes.d file can be used to reproduce the problem:

$ cat probes.d
provider null {
  probe null(void);
};

$ /usr/sbin/dtrace -s ./probes.d -h -o probes.h
dtrace: failed to compile script ./probes.d: "/usr/lib/dtrace/psinfo.d", line 46: syntax error near "u_int"

Even /dev/null can be used:

$ /usr/sbin/dtrace -s /dev/null -h -o probes.h
dtrace: failed to compile script /dev/null: "/usr/lib/dtrace/psinfo.d", line 46: syntax error near "u_int"
>Fix:
This feels like that dtrace should internally include sys/types.h (or sys/param.h) on NetBSD