Re: standards/57807: #include <arpa/inet.h> spuriously defines le32enc/be32enc/... under _XOPEN_SOURCE=700

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

Followup tools build fix needed:

https://mail-index.netbsd.org/source-changes/2024/09/11/msg153276.html

Module Name:    src
Committed By:   christos
Date:           Wed Sep 11 18:39:20 UTC 2024

Modified Files:
        src/external/cddl/osnet/sys/sys: types.h

Log Message:
- Remove conditional code for HAVE_NBTOOLS_CONFIG_H. The variable name was
  wrong anyway (it is HAVE_NBTOOL_CONFIG_H) so the code never worked as
  intended.
- Do not define _NETBSD_SOURCE even temporarily. It broke the tools
  build because <sys/types.h> includes <sys/endian.h> and with _NETBSD_SOURCE
  defined, this exposes the *enc and *dec functions which libctf redefines
  if it thinks that the system does not define them (and nbtools_config.h
  tells libctf that we are not defining them).


To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/external/cddl/osnet/sys/sys/types.h