NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: toolchain/58663: gpt(1) biosboot.c doesn't compile on modern Linux



The following reply was made to PR toolchain/58663; it has been noted by GNATS.

From: matthew green <mrg%eterna23.net@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: toolchain-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost
Subject: re: toolchain/58663: gpt(1) biosboot.c doesn't compile on modern Linux
Date: Wed, 04 Sep 2024 14:33:04 +1000

 > -       daddr_t start = 0;
 > +       off_t start = 0;        /* off_t because of gpt_human_get() */
 
 i think your change is generally correct, but it really indicates
 it much larger problem.
 
 daddr_t should be made to be 64-bit. (except for the cases where netbsd
 is building 32-bit daddr_t values for eg, old platform boot programs.)
  
 ie, this seems like it is *also* a compat issue we should fix, it may
 be causing weird issues elsewhere (but only when Huge Images?)
 
 
 .mrg.
 


Home | Main Index | Thread Index | Old Index