lib/58651: tm(3): wrong type in man page for tm_gmtoff

[campbell+netbsd%mumble.net@localhost]

>Number:         58651
>Category:       lib
>Synopsis:       tm(3): wrong type in man page for tm_gmtoff
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 28 14:35:00 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, 9, ...
>Organization:
The NetGMT Longoffset
>Environment:
>Description:
The tm(3) man page says:

     In addition, the following NetBSD-specific fields are available:

           Type             Field      Represents
           int              tm_gmtoff  Offset from UTC in seconds
           __aconst char    tm_zone    Timezone abbreviation

However, tm_gmtoff has been long, not int, since this file was updated from 4.4-Lite in 1994.  (I would see if it went back any further, but I can't because the earlier history was scrubbed as required by the settlement in the AT&T lawsuit.)

Also, the __aconst is superfluous here.  It is used only for special builds of NetBSD that serve to verify we don't accidentally write to pointers that are supposed to be const but can't be exposed as such for whatever standards compliance reasons.
>How-To-Repeat:
code manspection
>Fix:
Yes, please!