kern/58586: vmx(4) locking issues

[campbell+netbsd%mumble.net@localhost]

>Number:         58586
>Category:       kern
>Synopsis:       vmx(4) locking issues
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Aug 12 16:25:00 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, ...
>Organization:
The NetVMX Resetation
>Environment:
>Description:
1. pci interrupt {vmxnet3_legacy_intr, vmxnet3_event_intr} -> vmxnet3_evintr -> vmxnet3_init_locked must be deferred to workqueue, like watchdog reset
2. lock taken in softint context must not be taken across init/stop -- nix `core' lock, replace by mcast lock for SIOCADDMULTI/SIOCDELMULTI and multicast filter updates at IPL_SOFTNET
3. vmx_if_flags is not initialized anywhere, it seems?
4. incoherent locking rule for vmxnet3_if_link_status and access to struct vmxnet3_softc::vmx_link_active (sometimes core lock, sometimes ifnet lock -- should be IPL_NET intr lock)
5. missing lock around access to struct vmxnet3_queue::vxq_wq_enqueued -- should be IPL_NET intr lock (or atomic ops)
>How-To-Repeat:
code inspection
>Fix:
Yes, please!