NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/58425 CVS commit: [netbsd-10] src
The following reply was made to PR kern/58425; it has been noted by GNATS.
From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc:
Subject: PR/58425 CVS commit: [netbsd-10] src
Date: Wed, 7 Aug 2024 10:04:48 +0000
Module Name: src
Committed By: martin
Date: Wed Aug 7 10:04:48 UTC 2024
Modified Files:
src/lib/libc/compat-43 [netbsd-10]: killpg.c
src/sys/kern [netbsd-10]: kern_descrip.c kern_ktrace.c kern_proc.c
sys_sig.c tty.c
src/tests/lib/libc/sys [netbsd-10]: t_kill.c
Log Message:
Pull up following revision(s) (requested by kre in ticket #773):
sys/kern/kern_proc.c: revision 1.276
sys/kern/kern_ktrace.c: revision 1.185
sys/kern/sys_sig.c: revision 1.58
sys/kern/kern_descrip.c: revision 1.263
lib/libc/compat-43/killpg.c: revision 1.10
sys/kern/tty.c: revision 1.313
tests/lib/libc/sys/t_kill.c: revision 1.2
PR kern/58425 -- Disallow INT_MIN as a (negative) pid arg.
Since -INT_MIN is undefined, and to point of negative pid args is
to negate them, and use the result as a pgrp id instead, we need
to avoid accidentally negating INT_MIN.
Since pid_t is just an integral type, of unspecified width, when
testing pid_t value test for <= INT_MIN (or > INT_MIN sometimes)
rather than == INT_MIN. When testing int values, just == INT_MIN
is all that is needed, < INT_MIN cannot occur.
tests/lib/libc/sys/t_kill: Test kill(INT_MIN, ...) fails with ESRCH.
PR kern/58425
To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.9.14.1 src/lib/libc/compat-43/killpg.c
cvs rdiff -u -r1.251.10.1 -r1.251.10.2 src/sys/kern/kern_descrip.c
cvs rdiff -u -r1.182 -r1.182.4.1 src/sys/kern/kern_ktrace.c
cvs rdiff -u -r1.269 -r1.269.2.1 src/sys/kern/kern_proc.c
cvs rdiff -u -r1.56 -r1.56.4.1 src/sys/kern/sys_sig.c
cvs rdiff -u -r1.307 -r1.307.2.1 src/sys/kern/tty.c
cvs rdiff -u -r1.1 -r1.1.56.1 src/tests/lib/libc/sys/t_kill.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Home |
Main Index |
Thread Index |
Old Index