PR/56252 CVS commit: src/sys/net

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR kern/56252; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/56252 CVS commit: src/sys/net
Date: Mon, 29 Jul 2024 16:02:05 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Mon Jul 29 16:02:05 UTC 2024
 
 Modified Files:
 	src/sys/net: if_wg.c
 
 Log Message:
 wg(4): Deduplicate session establishment actions.
 
 The actions to
 
 (a) record the last handshake time,
 (b) clear some handshake state,
 (c) transmit first data if queued, or (if initiator) keepalive, and
 (d) begin destroying the old session,
 
 were formerly duplicated between wg_handle_msg_resp (for when we're
 the initiator) and wg_task_establish_session (for when we're the
 responder).
 
 Instead, let's factor this out into wg_swap_session so there's only
 one copy of the logic.
 
 This requires moving wg_update_endpoint_if_necessary a little earlier
 in wg_handle_msg_resp -- which should be done anyway so that the
 endpoint is updated _before_ the session is published for the data tx
 path to use.
 
 Other than moving wg_update_endpoint_if_necessary a little earlier,
 no functional change intended.
 
 Post-fix tidying for:
 
 PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails
 PR kern/56252: wg(4) state machine has race conditions
 PR kern/58463: if_wg does not work when idle.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.121 -r1.122 src/sys/net/if_wg.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.