PR/56252 CVS commit: src/sys/net

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR kern/56252; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/56252 CVS commit: src/sys/net
Date: Sun, 28 Jul 2024 14:47:37 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Jul 28 14:47:37 UTC 2024
 
 Modified Files:
 	src/sys/net: if_wg.c
 
 Log Message:
 wg(4): Use 32-bit for times handled in rx/tx paths.
 
 The rx and tx paths require unlocked access to wgs_time_established
 (to decide whether it's time to rekey) and wgs_time_last_data_sent
 (to decide whether we need to reply to incoming data with a keepalive
 packet), so do it with atomic_load/store_*.
 
 On 32-bit platforms, we may not be able to do that on time_t.
 However, since sessions only last for a few minutes before
 reject-after-time kicks in and they are erased, 32 bits is plenty to
 record the durations that we need to record here, so this shouldn't
 introduce any new bugs even on hosts that exceed 136 years of uptime.
 
 Prompted by:
 
 PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails
 PR kern/56252: wg(4) state machine has race conditions
 PR kern/58463: if_wg does not work when idle.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.103 -r1.104 src/sys/net/if_wg.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.