Re: kern/58435: synaptics_aux_mid_button_scroll not working

["Marc Coquand" <marc@mccd.space>]

The following reply was made to PR kern/58435; it has been noted by GNATS.

From: "Marc Coquand" <marc@mccd.space>
To: <gnats-bugs%netbsd.org@localhost>, <kern-bug-people%netbsd.org@localhost>,
 <gnats-admin%netbsd.org@localhost>, <netbsd-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: kern/58435: synaptics_aux_mid_button_scroll not working
Date: Thu, 18 Jul 2024 10:11:19 -0500

 Hi Robert,
 
 I tested your changes and they also work! Thank you.
 
 I am very new to kernel development and trying to learn more, could I
 ask how you came to your solution?
 
 -- Marc
 
 On Thu Jul 18, 2024 at 3:00 AM -05, Robert Elz wrote:
 > The following reply was made to PR kern/58435; it has been noted by GNATS=
 .
 >
 > From: Robert Elz <kre%munnari.OZ.AU@localhost>
 > To: "Marc Coquand" <marc@mccd.space>
 > Cc: gnats-bugs%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
 > Subject: Re: kern/58435: synaptics_aux_mid_button_scroll not working
 > Date: Thu, 18 Jul 2024 14:59:38 +0700
 >
 >      Date:        Thu, 18 Jul 2024 00:30:03 +0000 (UTC)
 >      From:        "Marc Coquand" <marc@mccd.space>
 >      Message-ID:  <20240718003003.CD1F81A923A%mollari.NetBSD.org@localhost>
 > =20
 >    |  Since reporting this issue, I managed to create a fix that works on=
  my
 >    |  computer.
 >    | =20
 >    |  It seems the button code was wrong for my computer, not sure if the=
 re
 >    |  is a generic solution to the issue.
 > =20
 >  To me, your change makes it look like as if the following change might
 >  be a better one -- but I don't have any kind of (working) synatpics
 >  touchpad at the minute to test this.
 > =20
 >  I believe this will work for you, but I can't tell if it might break
 >  things for anyone else.
 > =20
 >  kre
 > =20
 >  Index: synaptics.c
 >  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 >  RCS file: /cvsroot/src/sys/dev/pckbport/synaptics.c,v
 >  retrieving revision 1.83
 >  diff -u -r1.83 synaptics.c
 >  --- synaptics.c	18 Apr 2024 17:35:53 -0000	1.83
 >  +++ synaptics.c	18 Jul 2024 07:52:59 -0000
 >  @@ -1700,11 +1700,11 @@
 >   		 * If the middle button is held, interpret movement as
 >   		 * scrolling.
 >   		 */
 >  +		buttons =3D (psc->buttons & 0x1f) | ((psc->buttons >> 5) & 0x7);
 >   		if (synaptics_aux_mid_button_scroll &&
 >  -		    dy && (psc->buttons & 0x2)) {
 >  +		    dy && (buttons & 0x2)) {
 >   			wsmouse_precision_scroll(psc->sc_wsmousedev, dx, dy);
 >   		} else {
 >  -			buttons =3D (psc->buttons & 0x1f) | ((psc->buttons >> 5) & 0x7);
 >   			wsmouse_input(psc->sc_wsmousedev,
 >   				buttons, dx, dy, dz, 0,
 >   				WSMOUSE_INPUT_DELTA);
 > =20
 > =20