Re: kern/58435: synaptics_aux_mid_button_scroll not working

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR kern/58435; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: "Marc Coquand" <marc@mccd.space>
Cc: gnats-bugs%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/58435: synaptics_aux_mid_button_scroll not working
Date: Thu, 18 Jul 2024 14:59:38 +0700

     Date:        Thu, 18 Jul 2024 00:30:03 +0000 (UTC)
     From:        "Marc Coquand" <marc@mccd.space>
     Message-ID:  <20240718003003.CD1F81A923A%mollari.NetBSD.org@localhost>
 
   |  Since reporting this issue, I managed to create a fix that works on my
   |  computer.
   |  
   |  It seems the button code was wrong for my computer, not sure if there
   |  is a generic solution to the issue.
 
 To me, your change makes it look like as if the following change might
 be a better one -- but I don't have any kind of (working) synatpics
 touchpad at the minute to test this.
 
 I believe this will work for you, but I can't tell if it might break
 things for anyone else.
 
 kre
 
 Index: synaptics.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/pckbport/synaptics.c,v
 retrieving revision 1.83
 diff -u -r1.83 synaptics.c
 --- synaptics.c	18 Apr 2024 17:35:53 -0000	1.83
 +++ synaptics.c	18 Jul 2024 07:52:59 -0000
 @@ -1700,11 +1700,11 @@
  		 * If the middle button is held, interpret movement as
  		 * scrolling.
  		 */
 +		buttons = (psc->buttons & 0x1f) | ((psc->buttons >> 5) & 0x7);
  		if (synaptics_aux_mid_button_scroll &&
 -		    dy && (psc->buttons & 0x2)) {
 +		    dy && (buttons & 0x2)) {
  			wsmouse_precision_scroll(psc->sc_wsmousedev, dx, dy);
  		} else {
 -			buttons = (psc->buttons & 0x1f) | ((psc->buttons >> 5) & 0x7);
  			wsmouse_input(psc->sc_wsmousedev,
  				buttons, dx, dy, dz, 0,
  				WSMOUSE_INPUT_DELTA);