Re: port-sparc/58352: ld: /usr/lib/libubsan.so: undefined reference to `__sync_val_compare_and_swap_8'

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On 2024/06/30 16:24, matthew green wrote:
> Rin Okuyama writes:
> > After some investigation, I've found that sanitizer already
> > has its own 64-bit atomic ops for platforms without them.
> >
> > With the attached patch:
> > - libasan works on i386
> > - libubsan works on i386, powerpc, and vax (with WIP patches)
> >
> > Yes, this adds some performance penalty for these platforms,
> > however, it is better than having extra diff to upstream, IMO.
>
> nice!  this seems more maintainable, if slower, and i suspect
> 32-bit platform users doing this are less common anyway.

Committed. Thanks for comment!

> amused it is (a) in "sanitizer_atomic_clang.h", which is also
> used by GCC, and (b) includes "sanitizer_atomic_clang_mips.h",
> which has nothing mips- or clang- specific in it.

Shrug ;) I've added XXX comment into the commit.

Thanks,
rin