PR/58366 CVS commit: src/sys/arch

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR port-amd64/58366; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58366 CVS commit: src/sys/arch
Date: Thu, 27 Jun 2024 23:58:47 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Thu Jun 27 23:58:47 UTC 2024
 
 Modified Files:
 	src/sys/arch/amd64/amd64: machdep.c
 	src/sys/arch/i386/i386: machdep.c
 
 Log Message:
 x86: Defer x86_rndseed until after pmap_bootstrap.
 
 Loading the random seed, which is what x86_rndseed does, requires
 direct map access on KASLR kernels, which requires pmap_bootstrap to
 have run.
 
 This had been broken in
 
 amd64/machdep.c 1.359
 i386/machdep.c 1.832
 
 because we apparently don't have any automatic test setup for KASLR
 kernels, which we should address.
 
 This change shouldn't cause any security regression on kernels that
 previously owrked, because none of the logic that now happens before
 x86_rndseed uses the entropy pool anyway (uvm_md_init,
 init_x86_clusters, xen_parse_cmdline).
 
 PR port-amd64/58366
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.368 -r1.369 src/sys/arch/amd64/amd64/machdep.c
 cvs rdiff -u -r1.841 -r1.842 src/sys/arch/i386/i386/machdep.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.