PR/58359 CVS commit: src/external/mit/libcbor/lib

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR lib/58359; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58359 CVS commit: src/external/mit/libcbor/lib
Date: Mon, 24 Jun 2024 18:01:04 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Mon Jun 24 18:01:04 UTC 2024
 
 Modified Files:
 	src/external/mit/libcbor/lib: Makefile
 
 Log Message:
 libcbor: Undo make dependencies `fix' and tidy up.
 
 1. There is no need for ${ALLOBJS} to depend on cbor/configuration.h,
    because cbor/configuration.h is already installed by make includes
    long before we get to make dependall, let alone make all.
 
 2. Now that we don't use ${ALLOBJS} in a rule, put bsd.lib.mk at the
    end where it normally belongs.
 
 3. Make the cbor/configuration.h recipe interruption-safe by writing
    to a temporary file first and then renaming it.
 
 4. Nix needless empty .BEGIN rule.  Pretty sure this doesn't do
    anything.
 
 My previous hypothesis about why this could have happened ceased to
 make sense once I realized that cbor/configuration.h is supposed to
 be installed in /usr/include.  I no longer have a hypothesis about
 how PR lib/58359 could have happened, unless perhaps the build had
 been previously interrupted, leaving an empty
 $DESTDIR/usr/include/cbor/configuration.h file.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/external/mit/libcbor/lib/Makefile
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.