bin/58324: btpand -s/-S waltzes off end of array

[campbell+netbsd%mumble.net@localhost]

>Number:         58324
>Category:       bin
>Synopsis:       btpand -s/-S waltzes off end of array
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 08 17:40:01 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10, 9, ...
>Organization:
The NetBT*D Foundation
>Environment:
>Description:
If passed an argument other than `PANU', `NAP', or `GN' (case-insensitive) to the `-s' or `-S' option, btpand(8) program waltzes off the end of array and crashes into oblivion.

This has been fixed in HEAD but not yet pulled up:

https://mail-index.netbsd.org/source-changes/2024/06/04/msg151635.html
>How-To-Repeat:
btpand -s 'I would like to order one undefined behaviour, please'
>Fix:
check bounds before comparing entry, not after