Re: lib/58319: usr.bin/mklocale/Makefile misdefines NBCHAR_MAX

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Fri, 07 Jun 2024 21:31:31 -0700
> From: Collin Funk <collin.funk1%gmail.com@localhost>
> 
> Taylor R Campbell <riastradh%NetBSD.org@localhost> writes:
> 
> > As a side effect, this created two empty directories in /tmp both
> > called `-p.<randomchars>'.  It looks like the gnulib test suite is not
> > fully cleaning up after itself, in particular test-init.sh and
> > test-verify.sh.
> 
> Thanks for testing that. Sorry about the uncleaned directories. What
> shell were you using? I'm not too familiar with the shell test framework
> written for Gnulib so I might have to forward it to someone else.

My interactive shell is zsh, but I doubt whether that's relevant
because the scripts look like they are sensibly written to use
#!/bin/sh.

I also just noticed that running `./gnulib-tool --create-testdir ...'
had left a directory $TMPDIR/gnulib-python-cache-riastradh lying
around.

> Also, the original report was in a Docker container with glibc and
> qemu-user or something. So nothing to worry about in NetBSD, the problem
> was somewhere in that combination. No harm in removing a confusing
> define though.

Yes, thanks, we should still clarify the NBCHAR_MAX business and/or
remove it, so I'll leave the PR open until we do one or the other.