Re: lib/58319: usr.bin/mklocale/Makefile misdefines NBCHAR_MAX

[Collin Funk <collin.funk1%gmail.com@localhost>]

The following reply was made to PR lib/58319; it has been noted by GNATS.

From: Collin Funk <collin.funk1%gmail.com@localhost>
To: Taylor R Campbell <riastradh%NetBSD.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost,  netbsd-bugs%NetBSD.org@localhost
Subject: Re: lib/58319: usr.bin/mklocale/Makefile misdefines NBCHAR_MAX
Date: Fri, 07 Jun 2024 21:31:31 -0700

 Hi Taylor,
 
 Taylor R Campbell <riastradh%NetBSD.org@localhost> writes:
 
 > PASS: test-localeconv
 > ...
 > # TOTAL: 17
 > # PASS:  17
 > # SKIP:  0
 > # XFAIL: 0
 > # FAIL:  0
 > # XPASS: 0
 > # ERROR: 0
 >
 > As a side effect, this created two empty directories in /tmp both
 > called `-p.<randomchars>'.  It looks like the gnulib test suite is not
 > fully cleaning up after itself, in particular test-init.sh and
 > test-verify.sh.
 
 Thanks for testing that. Sorry about the uncleaned directories. What
 shell were you using? I'm not too familiar with the shell test framework
 written for Gnulib so I might have to forward it to someone else.
 
 > All that said, mklocale doesn't actually use global_locale.c at all.
 > The use of NBCHAR_MAX in global_locale.c appears to have been a
 > mistake in this commit:
 >
 > https://mail-index.NetBSD.org/source-changes/2012/03/21/msg033103.html
 >
 > Even if mklocale has a legitimate need for the NBCHAR_MAX hook, I see
 > no reason to use that hook in global_locale.c.  So I'll remove it.
 >
 > But that still leaves me puzzled about why we have this apparently
 > harmless but useless NBCHAR_MAX hook in mklocale, with no explanation
 > in the commit message or history.
 
 Thanks for looking into it and looking through the archives. It seems
 like that definition was just a no-op then. Since it is not used in
 global_locale.c it makes sense that the test case passed and
 localeconv() works correctly. No bug then, sorry for the panic. :)
 
 Also, the original report was in a Docker container with glibc and
 qemu-user or something. So nothing to worry about in NetBSD, the problem
 was somewhere in that combination. No harm in removing a confusing
 define though.
 
 Collin