port-amd64/58316: Building amd64 with MKZFS=no still attempts to build ramdisk-zfsroot

[sotiris%lamprinidis.com@localhost]

>Number:         58316
>Category:       port-amd64
>Synopsis:       Building amd64 with MKZFS=no still attempts to build ramdisk-zfsroot
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-amd64-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 05 16:30:00 +0000 2024
>Originator:     Sotiris Lamprinidis
>Release:        10.0
>Organization:
N/A
>Environment:
Darwin 23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:12:58 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6000 arm64

>Description:
In distrib/amd64/ramdisks/Makefile, ramdisk-zfsroot gets built unconditionally. One would assume that using MKZFS=no this would be skipped.
>How-To-Repeat:
./build.sh -ax86_64 -mamd64  -VMKZFS=no release  
>Fix:
Condition building ramdisk-zfsroot on the MKZFS variable:

Index: distrib/amd64/ramdisks/Makefile
===================================================================
RCS file: /cvsroot/src/distrib/amd64/ramdisks/Makefile,v
retrieving revision 1.4.20.1
diff -u -u -r1.4.20.1 Makefile
--- distrib/amd64/ramdisks/Makefile 23 Feb 2024 18:07:24 -0000  1.4.20.1
+++ distrib/amd64/ramdisks/Makefile 23 Apr 2024 15:30:03 -0000
@@ -3,7 +3,9 @@
 SUBDIR=
 SUBDIR+= ramdisk
 SUBDIR+= ramdisk-cgdroot
+.if !empty(MKZFS:tl:My*)
 SUBDIR+= ramdisk-zfsroot
+.endif

 TARGETS+=  release