Re: install/58288: 10.0 (final) sysinst terminated after "Window too short..." message on a EFI netbook EeePC

[Radim Lysek <radim.lysek%atlas.cz@localhost>]

The following reply was made to PR install/58288; it has been noted by GNATS.

From: Radim Lysek <radim.lysek%atlas.cz@localhost>
To: <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: install/58288: 10.0 (final) sysinst terminated after "Window too
 short..." message on a EFI netbook EeePC
Date: Thu, 30 May 2024 18:47:09 +0200

 Dear Michael;
 
 many Thanks for your patch, so briefly coded and presented. It seems to me,=
  that this patch is based on editing of  sourcecode and lead to necessity o=
 f complilng of patched code. As i stated before, i am really a NetBSD newbi=
 e, so it is for me in this momentum not usual (or reachable) to sucessfully=
  fulfill this attempt :-(
 I hope i am able to change newly compilled binaries on the installation med=
 ia (SD card) an repeat this installation.
 
 Please: can you help me with compilling and sending the compilled binaries?
 
 Thnx many times!
 Radim
 
 ______________________________________________________________
 > Od: mlelstv%serpens.de@localhost
 > Komu: install-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs@net=
 bsd.org, radim.lysek%atlas.cz@localhost
 > Datum: 28.05.2024 22:25
 > P=C5=99edm=C4=9Bt: Re: install/58288: 10.0 (final) sysinst terminated aft=
 er "Window too short..." message on a EFI netbook EeePC
 >
 >The following reply was made to PR install/58288; it has been noted by GNA=
 TS.
 >
 >From: mlelstv%serpens.de@localhost (Michael van Elst)
 >To: gnats-bugs%netbsd.org@localhost
 >Cc:=20
 >Subject: Re: install/58288: 10.0 (final) sysinst terminated after "Window =
 too short..." message on a EFI netbook EeePC
 >Date: Tue, 28 May 2024 20:21:34 -0000 (UTC)
 >
 > martin%duskware.de@localhost (Martin Husemann) writes:
 >=20
 > > and the 10.0 kernel apparently does not select a usable font size for
 > > the 1024 x 600 resolution (or it miss-probes the monitor size).
 >=20
 >=20
 > Here is a patch that might help.
 >=20
 > It prefers the wide font only when you have at least 1280 pixels
 > (8 * 80 * 2) and it choses the narrow font if both score equally.
 >=20
 > Index: sys/dev/wsfont/wsfont.c
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /cvsroot/src/sys/dev/wsfont/wsfont.c,v
 > retrieving revision 1.80
 > diff -p -u -r1.80 wsfont.c
 > --- sys/dev/wsfont/wsfont.c	19 Feb 2023 05:35:35 -0000	1.80
 > +++ sys/dev/wsfont/wsfont.c	28 May 2024 20:14:18 -0000
 > @@ -619,15 +619,11 @@ wsfont_matches(struct wsdisplay_font *fo
 >  				return (0);
 >  		} else {
 >  			if (font->fontwidth > width) {
 > -				score -=3D uimin(font->fontwidth - width, 9999);
 > -				if ((flags & WSFONT_PREFER_WIDE) =3D=3D 0) {
 > -					score -=3D 10000;
 > -				}
 > +				score -=3D uimin(font->fontwidth - width, 4999) * 2 + 1;
 >  			} else {
 > -				score -=3D uimin(width - font->fontwidth, 9999);
 > -				if ((flags & WSFONT_PREFER_WIDE) !=3D 0) {
 > +				score -=3D uimin(width - font->fontwidth, 4999) * 2;
 > +				if ((flags & WSFONT_PREFER_WIDE) !=3D 0)
 >  					score -=3D 10000;
 > -				}
 >  			}
 >  		}
 >  	}
 > Index: sys/dev/wsfb/genfb.c
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /cvsroot/src/sys/dev/wsfb/genfb.c,v
 > retrieving revision 1.91
 > diff -p -u -r1.91 genfb.c
 > --- sys/dev/wsfb/genfb.c	20 Jan 2024 00:24:58 -0000	1.91
 > +++ sys/dev/wsfb/genfb.c	28 May 2024 20:14:18 -0000
 > @@ -777,12 +777,14 @@ static int
 >  genfb_calc_cols(struct genfb_softc *sc, struct rasops_info *ri)
 >  {
 >  	const int hsize =3D genfb_calc_hsize(sc);
 > +	const int cols =3D hsize ? hsize / GENFB_CHAR_WIDTH_MM : RASOPS_DEFAULT=
 _WIDTH;
 > =20
 > -	if (hsize !=3D 0) {
 > +	if (hsize !=3D 0 &&
 > +	    cols > 2 * RASOPS_DEFAULT_WIDTH) {
 >  		ri->ri_flg |=3D RI_PREFER_WIDEFONT;
 >  	}
 > =20
 > -	return MAX(RASOPS_DEFAULT_WIDTH, hsize / GENFB_CHAR_WIDTH_MM);
 > +	return MIN(cols, hsize / GENFB_CHAR_WIDTH_MM);
 >  }
 > =20
 >  static int
 >=20
 >=20
 >
 >