bin/58299: icmp(8) uses unusual/inconsistent terminology

[John.P.Darrow%gmail.com@localhost]

>Number:         58299
>Category:       bin
>Synopsis:       icmp(8) uses unusual/inconsistent terminology
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 29 04:10:00 +0000 2024
>Originator:     John Darrow
>Release:        all branches through post-10 current
>Organization:
mostly piles
>Environment:
pick a version, any version
>Description:
icmp(8) mixes use of the terms 'ECHO_REPLY' and 'ECHO_RESPONSE' for referring to an ICMP Echo Reply packet.  This is inconsistent with both the code, and RFC 792, which consistently uses the term "Reply".
>How-To-Repeat:
man 8 ping
>Fix:
simplest: s/ECHO_RESPONSE/ECHO_REPLY/g in icmp.8 for basic consistency.

arguably, then s/ECHO_REQUEST/ICMP_ECHO/g and s/ECHO_REPLY/ICMP_ECHOREPLY/g to match the actual code in ping.c and /usr/include/netinet/ip_icmp.h .

(Also note as a point of reference that our IPv6 uses ICMP6_ECHO_REQUEST and ICMP6_ECHO_REPLY, with the additional internal underscore; but it also has its own separate ping6 utility.)