Re: bin/53513 (agrep no longer works since 8.0)

[andvar%NetBSD.org@localhost]

Synopsis: agrep no longer works since 8.0

Responsible-Changed-From-To: bin-bug-people->andvar
Responsible-Changed-By: andvar%NetBSD.org@localhost
Responsible-Changed-When: Mon, 20 May 2024 20:13:09 +0000
Responsible-Changed-Why:
taking in attempt to fix.


State-Changed-From-To: open->analyzed
State-Changed-By: andvar%NetBSD.org@localhost
State-Changed-When: Mon, 20 May 2024 20:13:09 +0000
State-Changed-Why:
agrep got partially broken after agrep.c rev 1.3 introduced recursive search
and binary file detection. isbinaryfile() returns true if file fails to open,
which is always the case for stdin. Because of this stdin fails in the reported
PR example. Also this binary check is called on every line, making it
inefficient and it duplicates the result for the every binary line in the file.