Re: lib/58254: define_key ncurses compat function is incompatible with ncurses

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

The following reply was made to PR lib/58254; it has been noted by GNATS.

From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: Brett Lymn <blymn%internode.on.net@localhost>
Subject: Re: lib/58254: define_key ncurses compat function is incompatible
 with ncurses
Date: Wed, 15 May 2024 03:42:37 +0300

 > It is probably harmless but we have changed the interface.
 
 I don't think we have.  The symbol is still there with the same name
 (there's no C++ name mangling) and the behaviour of the function is
 not changed.  It might actually be the exact same binary, unless gcc
 can get some optimizations out of that promise that the contents of
 the string is not changed, but it should probably have that infered
 already anyway as the internal function is static to the file.
 
 No existing binary that uses this symbol is going to notice anything.
 
 PS: I noticed we have at least one more missing const, I'll try to
 gover over the spec when I have free time closer to the weekend.
 
 -uwe