bin/57993: certctl(8) is too slow

[campbell+netbsd%mumble.net@localhost]

>Number:         57993
>Category:       bin
>Synopsis:       certctl(8) is too slow
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 03 14:45:01 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10
>Organization:
The CertBSD Installation
>Environment:
>Description:
`certctl rehash' took several minutes to run in my aarch64 qemu VM -- that's way too slow.  `certctl list' alone takes over a minute.

A lot of the time is spent in running vis subprocesses, which it uses to guarantee safe operation as a shell script even if you put funny characters in your certificate file names.  Not sure there's a good way to speed that up without losing the safety (short of rewriting it in C).

Looks like the basename subprocesses in list_default_trusted can be elided with judicious shell parameter expansion, though.
>How-To-Repeat:
run certctl on a slow machine
>Fix:
Yes, please!