Re: misc/57945: makefs: msdos filesystems with label not reproducible

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR misc/57945; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: misc/57945: makefs: msdos filesystems with label not reproducible
Date: Sun, 18 Feb 2024 18:01:24 +0100

 The problem is the argument order: if you move the -T before the -o
 argument, it all seems to work fine.
 
 -T sets "stampst" (src/usr.sbin/makefs/makefs.c:257) and that is
 only transfered to the msdos specific options in 
 src/usr.sbin/makefs/msdos.c:msdos_parse_opts if that is called later.
 
 Maybe add a "dummy" final call after the getopt loop like
 
 	fstype->parse_options(NULL, &fsoptions)
 
 and make all parse_options deal with the NULL?
 
 Martin